New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve lastModified timestamp in setInputFiles #27671

Merged

yury-s merged 9 commits into microsoft:main from yury-s:lastModified

Oct 18, 2023

Member

yury-s commented Oct 17, 2023

Fixes #27452


          fix: preserve lastModified timestamp in setInputFiles

937fdb4

dgozman approved these changes

View reviewed changes

packages/playwright-core/src/client/elementHandle.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/elementHandle.ts Outdated Show resolved Hide resolved

packages/playwright-core/src/client/elementHandle.ts Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

yury-s added 2 commits

October 17, 2023 18:12


          Address comments

58154cc


          Update timestamp expectation

6c21e41

This comment has been minimized.

Sign in to view


          round instead of trunc

1295ae8

This comment has been minimized.

Sign in to view

yury-s added 2 commits

October 18, 2023 09:25


          Approximate comparison

19c5366


          Remove blank line

7edfe91

This comment has been minimized.

Sign in to view

yury-s added 2 commits

October 18, 2023 11:21


          More verbose logs

84aeddb


          Relax expectation, match ~1 second

c5114c8

This comment has been minimized.

Sign in to view


          fix lint

468c44f

This comment has been minimized.

Sign in to view

Contributor

github-actions bot commented Oct 18, 2023

Test results for "tests 1"

5 flaky

⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [firefox] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker

25897 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

yury-s merged commit bd58c0d into microsoft:main

yury-s deleted the lastModified branch

October 18, 2023 21:05

commit-lint bot mentioned this pull request

[pull] main from microsoft:main ammar-knowledge/playwright#69

Merged

iuliancmarcu commented Oct 23, 2023

Thanks for this work @yury-s 🙌🏼

mxschmitt mentioned this pull request

[internal] file upload Android tests are failing #27792

Closed

Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request


          fix: preserve lastModified timestamp in setInputFiles (microsoft#27671)

901f52a

Fixes microsoft#27452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet