Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make sure that we print warning for unsupported OS #27610

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Oct 13, 2023

Also, fix some missing paths in download lists.

Also, fix some missing paths in download lists.
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-cdn.spec.ts:40:7 › playwright cdn failover should work (https://playwright.azureedge.net)

8 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

25852 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman added the CQ1 label Oct 15, 2023
@github-actions
Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test

103 flaky ⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [chromium] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/capabilities.spec.ts:139:3 › should not crash on showDirectoryPicker
⚠️ [chromium] › page/elementhandle-scroll-into-view.spec.ts:103:3 › should wait for element to stop moving
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/trace-viewer.spec.ts:346:1 › should contain adopted style sheets
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/channels.spec.ts:141:1 › should scope browser handles
⚠️ [firefox] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2
⚠️ [firefox] › library/video.spec.ts:601:5 › screencast › should throw on browser close
⚠️ [firefox] › library/video.spec.ts:695:5 › screencast › should capture full viewport
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page\frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/inspector/cli-codegen-1.spec.ts:520:7 › cli codegen › should uncheck
⚠️ [firefox] › library/inspector/cli-codegen-javascript.spec.ts:39:5 › should print the correct context options for custom settings
⚠️ [firefox] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [firefox] › library/inspector/cli-codegen-pytest.spec.ts:23:5 › should print the correct imports and context options
⚠️ [firefox] › library/inspector/cli-codegen-python.spec.ts:26:5 › should print the correct imports and context options
⚠️ [firefox] › library/launcher.spec.ts:29:3 › should kill browser process on timeout after close
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:695:5 › screencast › should capture full viewport
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:695:5 › screencast › should capture full viewport
⚠️ [firefox] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [firefox] › library\browsertype-connect.spec.ts:175:5 › run-server › should be able to visit ipv6 through localhost
⚠️ [firefox] › library\inspector\cli-codegen-csharp.spec.ts:213:5 › should print a valid basic program in mstest
⚠️ [firefox] › library\signals.spec.ts:25:5 › should close the browser when the node process closes
⚠️ [firefox] › library\trace-viewer.spec.ts:872:1 › should display language-specific locators
⚠️ [firefox] › library\tracing.spec.ts:288:5 › should overwrite existing file
⚠️ [firefox] › library\tracing.spec.ts:482:5 › should work with multiple chunks
⚠️ [firefox] › page\elementhandle-scroll-into-view.spec.ts:119:3 › should timeout waiting for visible
⚠️ [firefox] › page\page-click-scroll.spec.ts:19:3 › should not hit scroll bar
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-events.spec.ts:19:5 › console event should work @smoke
⚠️ [chromium] › library/browsercontext-events.spec.ts:77:5 › dialog event should work @smoke
⚠️ [chromium] › page/page-screenshot.spec.ts:752:5 › page screenshot animations › should trigger particular events for css transitions
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost
⚠️ [chromium] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local
⚠️ [chromium] › library/trace-viewer.spec.ts:1050:1 › should highlight locator in iframe while typing
⚠️ [chromium] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts:337:3 › should work if not doing a drag
⚠️ [chromium] › library/screenshot.spec.ts:64:14 › page screenshot › should work with a mobile viewport and fullPage
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/chromium/connect-over-cdp.spec.ts:43:5 › should cleanup artifacts dir after connectOverCDP disconnects due to ws close
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:227:7 › cli codegen › should fill
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library\browsercontext-basic.spec.ts:169:3 › should return all of the pages
⚠️ [webkit] › library\browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts
⚠️ [webkit] › library\har.spec.ts:438:3 › should return receive time
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:55:7 › cli codegen › should ignore programmatic events
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:667:7 › cli codegen › should assert navigation
⚠️ [webkit] › library\inspector\cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page\locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [webkit] › page\page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [webkit] › page\page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit] › page\page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

169729 passed, 7610 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit d83d9ce into microsoft:main Oct 16, 2023
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Oct 18, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants