feat(html-report): Keep query when clicking project filter + ability to right-click #35400
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 failed 4 flaky38933 passed, 805 skipped Merge workflow run. |
|
Failed tests seem flaky to me |
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
The change looks good. Please try reverting the unrelated newline changes where possible.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Chris <57954026+cpAdm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"4 flaky38935 passed, 805 skipped Merge workflow run. |
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
Thank you for the PR! There is one small caveat I'd like to resolve, but otherwise looks awesome.
| projectName: string, | ||
| }> = ({ projectNames, projectName }) => { | ||
| const encoded = encodeURIComponent(projectName); | ||
| const value = projectName === encoded ? projectName : `"${encoded.replace(/%22/g, '%5C%22')}"`; |
There was a problem hiding this comment.
I think this logic was here to support project names with spaces/quotes inside. Otherwise, tokenizing p:my project will yield two tokens instead of a single one with "my project" as a project name. I guess we should add a test as well.
There was a problem hiding this comment.
Makes sense. Should I make it generic such that it also works for annotations and such?
| header={<span> | ||
| {file.fileName} | ||
| </span>}> | ||
| header={<span>{file.fileName}</span>} |
There was a problem hiding this comment.
Seems like unrelated formatting change?
|
I won't have the time to complete this. So closing. |
3 participants
Implements points:
Ctrl+ click should also work with project labels (and not open new tab)Note: The full query now gets properly escaped, this does mean that the URL looks different. However, old URLs still work.
References: #35212