chore: browser._launchServer #37031
Merged
chore: browser._launchServer #37031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Aug 14, 2025
| }, | ||
|
|
||
| onConnection: (request, url, ws, id) => { | ||
| if (url.searchParams.has('debug-controller')) { |
Contributor
There was a problem hiding this comment.
I think we don't want this available on every server, so let's make it configurable.
| import { connectOverWebSocket } from './webSocket'; | ||
| import { TimeoutSettings } from './timeoutSettings'; | ||
|
|
||
| import type { Browser as BrowserImpl } from '../server/browser'; |
Contributor
There was a problem hiding this comment.
I think everything goes wrong with the bots because we should not import server code from the client side. I'd recommend making launchServerOnExistingBrowser taking a client-side Browser instead.
Member
Author
There was a problem hiding this comment.
i tried that in 820fd7f, but typescript still doesn't like it. how curious 🤔
Member
Author
There was a problem hiding this comment.
oh, the real problem was that I imported from src instead of lib in a test.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 15, 2025
| host?: string, | ||
| port?: number, | ||
| wsPath?: string, | ||
| debugController?: boolean; |
Contributor
There was a problem hiding this comment.
Keep it private please.
Suggested change
| debugController?: boolean; | |
| _debugController?: boolean; |
| try { | ||
| const connection = this._delegate.onConnection(request, url, ws, id); | ||
| (ws as any)[kConnectionSymbol] = connection; | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
Lovely! I was about to comment that we should handle exceptions 😄
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"2 failed 21 flaky46594 passed, 803 skipped Merge workflow run. |
Skn0tt
added a commit
to Skn0tt/playwright
that referenced
this pull request
Oct 1, 2025
This reverts commit 3fdbc06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a private method for launching a playwright server for an existing browser, for usage from inside MCP.