Skip to content

chore(agent): expectURL #38812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 6 commits into from
Jan 16, 2026
Merged

chore(agent): expectURL #38812

Skn0tt merged 6 commits into from
Jan 16, 2026

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 16, 2026

No description provided.

@Skn0tt Skn0tt requested a review from dgozman January 16, 2026 14:01
@Skn0tt Skn0tt self-assigned this Jan 16, 2026
dgozman
dgozman approved these changes Jan 16, 2026
View reviewed changes
packages/playwright-core/src/server/agent/actionRunner.ts
Comment on lines +128 to +131
if (!action.regex && !action.value)
throw new Error('Either url or regex must be provided');
if (action.regex && action.value)
throw new Error('Only one of url or regex can be provided');
Copy link
Contributor

@dgozman dgozman Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be expressed in zod schema somehow? union({ value }, { regex }) perhaps?

Copy link
Member Author

@Skn0tt Skn0tt Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but then it becomes incompatible with zod.discriminatedUnion. We'd have to use zod.union instead, which is more expensive to validate.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Test results for "tests 1"

24 failed
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @ubuntu-22.04-chromium-tip-of-tree
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node24
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node20
❌ [chromium-library] › library/agent-expect.spec.ts:223 › expectURL success @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:261 › expectURL with regex @chromium-ubuntu-22.04-node22
❌ [chromium-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @chromium-ubuntu-22.04-node22
❌ [firefox-library] › library/agent-expect.spec.ts:223 › expectURL success @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:261 › expectURL with regex @firefox-ubuntu-22.04-node20
❌ [firefox-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:223 › expectURL success @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:241 › expectURL wrong URL error @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:261 › expectURL with regex @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/agent-expect.spec.ts:279 › expectURL with regex error @webkit-ubuntu-22.04-node20

3 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT `@macos-latest-node20`

34570 passed, 691 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Test results for "MCP"

3 failed
❌ [chrome] › mcp/autowait.spec.ts:19 › racy navigation destroys context @mcp-windows-latest
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [firefox] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15

2827 passed, 121 skipped

Merge workflow run.

@Skn0tt Skn0tt merged commit 02b8f53 into microsoft:main Jan 16, 2026
24 of 32 checks passed
This was referenced Jan 16, 2026
Open
Open
Open
@Skn0tt Skn0tt mentioned this pull request Jan 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt @dgozman