Skip to content

chore: hide stuff #38882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 4 commits into from
Jan 22, 2026
Merged

chore: hide stuff #38882

Skn0tt merged 4 commits into from
Jan 22, 2026

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 21, 2026

Not ready for primetime!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Skn0tt Skn0tt marked this pull request as ready for review January 21, 2026 14:10
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Test results for "MCP"

2 failed
❌ [webkit] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [webkit] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15

2817 passed, 106 skipped

Merge workflow run.

dgozman
dgozman approved these changes Jan 22, 2026
View reviewed changes
packages/playwright/src/common/config.ts
reportSlowTests: takeFirst(userConfig.reportSlowTests, { max: 5, threshold: 300_000 /* 5 minutes */ }),
runAgents: takeFirst(configCLIOverrides.runAgents, userConfig.runAgents, 'none'),
// @ts-expect-error runAgents is hidden
runAgents: takeFirst(configCLIOverrides.runAgents, 'none'),
Copy link
Contributor

@dgozman dgozman Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future - this should move from FullConfig to FullConfigInternal

@Skn0tt Skn0tt merged commit 0c1b64c into microsoft:main Jan 22, 2026
28 of 32 checks passed
This was referenced Jan 22, 2026
Open
Closed
Open
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Test results for "tests 1"

12 failed
❌ [default] › debug-tests.spec.ts:172 › should debug one test and pause on error @vscode-extension
❌ [default] › debug-tests.spec.ts:237 › should debug error @vscode-extension
❌ [default] › debug-tests.spec.ts:313 › should end test run when stopping the debugging during config parsing @vscode-extension
❌ [default] › debug-tests.spec.ts:380 › should run global setup before debugging @vscode-extension
❌ [default] › debug-tests.spec.ts:431 › should debug global setup when toggle is enabled @vscode-extension
❌ [default] › debug-tests.spec.ts:516 › should not pause at the end of a setup test @vscode-extension
❌ [playwright-test] › playwright.trace.spec.ts:137 › should not throw with trace: on-first-retry and two retries in the same worker @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:140 › should format JSON request body @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:287 › should copy network request @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:353 › should not preserve selection across test runs @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:592 › update-source-method › should overwrite source @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

7 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:226 › cli codegen › should generate frame locators (4) `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:183 › should show snapshots for steps `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:426 › should work behind reverse proxy `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:688 › should indicate current test status `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:796 › should update state on subsequent run `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:748 › should partition action tree state by test `@windows-latest-node20`

34654 passed, 695 skipped

Merge workflow run.

Skn0tt added a commit that referenced this pull request Jan 23, 2026
@Skn0tt
Revert "chore: hide stuff (#38882)"
01947ca 
This reverts commit 0c1b64c.
@Skn0tt Skn0tt mentioned this pull request Jan 23, 2026
Merged
Skn0tt added a commit to Skn0tt/playwright that referenced this pull request Jan 23, 2026
@Skn0tt
chore(doclint): handle hidden metadata earlier in parsing
16a696a 
This reapplies the doclint improvements from microsoft#38882 that were
accidentally reverted in microsoft#38917.

The changes:
- Check for hidden metadata early in parseMember, before looking up
  the class (allows hiding members on hidden classes)
- Check for hidden metadata in parseArgument for params/options
  (allows hiding individual parameters)
@Skn0tt Skn0tt mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Skn0tt @dgozman