Skip to content

Revert "chore: hide stuff" #38917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Skn0tt merged 1 commit into from
Jan 23, 2026
Merged

Revert "chore: hide stuff" #38917

Skn0tt merged 1 commit into from
Jan 23, 2026

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 23, 2026

Reverts #38882

@Skn0tt Skn0tt self-assigned this Jan 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Test results for "tests 1"

6 failed
❌ [playwright-test] › global-setup.spec.ts:313 › globalSetup should work for auth @macos-latest-node20
❌ [playwright-test] › playwright.artifacts.spec.ts:127 › should work with screenshot: on @macos-latest-node20
❌ [playwright-test] › playwright.trace.spec.ts:290 › should not override trace file in afterAll @macos-latest-node20
❌ [playwright-test] › playwright.trace.spec.ts:1119 › trace:retain-on-first-failure should create trace if context is closed before failure in afterEach @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:1037 › created › should have link for opening HTML attachments in new tab @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20

4 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`

34663 passed, 695 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Test results for "MCP"

12 failed
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:162 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15
❌ [webkit] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15

3094 passed, 300 skipped

Merge workflow run.

@Skn0tt Skn0tt merged commit 71c4240 into main Jan 23, 2026
28 of 32 checks passed
@Skn0tt Skn0tt deleted the revert-38882-hide-md-and-agents branch January 23, 2026 12:56
This was referenced Jan 23, 2026
Open
Open
Open
Skn0tt added a commit to Skn0tt/playwright that referenced this pull request Jan 23, 2026
@Skn0tt
chore(doclint): handle hidden metadata earlier in parsing
16a696a 
This reapplies the doclint improvements from microsoft#38882 that were
accidentally reverted in microsoft#38917.

The changes:
- Check for hidden metadata early in parseMember, before looking up
  the class (allows hiding members on hidden classes)
- Check for hidden metadata in parseArgument for params/options
  (allows hiding individual parameters)
@Skn0tt Skn0tt mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman dgozman dgozman approved these changes

Assignees

@Skn0tt Skn0tt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Skn0tt @dgozman