Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Composition support for keyboard.imeSetComposition #9535

Closed
wants to merge 2 commits into from

Conversation

trueadm
Copy link

@trueadm trueadm commented Oct 15, 2021

Notes:

This PR implements the keyboard composition API keyboard.imeSetComposition. This makes it possible to test low-level IME related composition interactions.

Example:

  await page.focus('textarea');
  await page.keyboard.imeSetComposition('s', 1, 1);
  await page.keyboard.imeSetComposition('す', 1, 1);
  await page.keyboard.imeSetComposition('すs', 2, 2);
  await page.keyboard.imeSetComposition('すsh', 3, 3);
  await page.keyboard.imeSetComposition('すし', 2, 2);
  await page.keyboard.insertText('すし');

You might be wondering what, what about triggering of keyboard events such as keyboard.up, keyboard.press, keyboard.down etc, Rather than couple this PR with other discussions (see #7659) I think this can be worked on separately. Having imeSetComposition available sooner will be invaluable right now and help inform us of the discussions around how key events should work, and what their API should be.

@ghost
Copy link

ghost commented Oct 15, 2021

CLA assistant check
All CLA requirements met.

Fix bugs

Add tests for unimplemented browsers

Add Firefox imeSetComposition support

Revert

Fix lint

Revise

Revert

Remove browser patch changes

Add wk API

Fix types

Revise API
@trueadm trueadm force-pushed the imeSetComposition branch from b16cd95 to efaa759 Compare May 17, 2022 14:08
@pavelfeldman
Copy link
Member

Closing as stale due to no progress (on our side). I'm not sure the action for this should be, but it seems like we aren't ready for ime API at this point.

@trueadm
Copy link
Author

trueadm commented Dec 1, 2022

@pavelfeldman Has there been any further interest in adding the IME/Composition API internally. I was of the understanding that this was regarded as important from the Microsoft Editor folks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants