browser(firefox): Page.setComposition #9921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
force-pushed
the
ff-setComposition
branch
from
8d56791 to
b2da497
Compare
mxschmitt
reviewed
Nov 1, 2021
trueadm
force-pushed
the
ff-setComposition
branch
from
43ecf6c to
3b60ad1
Compare
mxschmitt
reviewed
Nov 1, 2021
trueadm
force-pushed
the
ff-setComposition
branch
4 times, most recently
from
efa1aa1 to
6a3d326
Compare
mxschmitt
reviewed
Nov 1, 2021
trueadm
force-pushed
the
ff-setComposition
branch
3 times, most recently
from
bc0d444 to
f5afd61
Compare
mxschmitt
approved these changes
Nov 1, 2021
trueadm
force-pushed
the
ff-setComposition
branch
from
f5afd61 to
3a33877
Compare
JoelEinbinder
suggested changes
Nov 4, 2021
| } else { | ||
| const selection = window.getSelection(); | ||
| const anchorNode = selection.anchorNode; | ||
| selection.setBaseAndExtent(anchorNode, replacementStart, anchorNode, replacementEnd); |
There was a problem hiding this comment.
This doesn't look quite right. Aside from the shadow dom issues, the macOS api this is modeled after expects this range to be in terms of the current root editable node. However your code is in terms of the leaf editable node.
You can see this code in TextInputHandler.mm : IMEInputHandler::SetMarkedText, which ends up in the web process as ContentEventHandler::OnSelectionEvent. I am working on a patch to fix this but I'm not sure if I should duplicate the logic in JavaScript or add a hack for us to call the c++ code directly.
raghavthind2005
approved these changes
Apr 26, 2022
|
Closing due to no progress (on our side). I'm not sure what the action for this should be, but we aren't considering adding composition API at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the Firefox browser patches changes from #9535.