Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Description In local mode, we first attempt to use the configured `document_nodes_file` if it's valid, otherwise, we fall back to `documents_folder`. In cloud mode, `document_nodes_file` is used if configured, without any validity checks because we cannot check if it is a data asset. For cloud mode, both local files and data assets can be used. **Local Tests:** 1. happy path - skip split ![image](https://github.com/microsoft/promptflow/assets/75061414/a937b8fc-4843-474f-a506-d3d1de6a1053) - has split: `documents_folder = "..\..\docs\reference\tools-reference"` ![image](https://github.com/microsoft/promptflow/assets/75061414/ca0d3a2c-14a8-424a-a927-8cbbc5a73537) 2. invalid file path and folder path ![image](https://github.com/microsoft/promptflow/assets/75061414/c0ee9255-f853-49e2-af09-fc0b61410d56) **Cloud Tests:** 1. happy path (local and asset) - local path skip split: https://ml.azure.com/runs/tough_guava_3znwhjb9sc?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 has split: https://ml.azure.com/runs/happy_flower_kr0y3yy56z?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 - data asset path skip split: https://ml.azure.com/runs/frosty_raisin_tsrhm41knv?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 has split: https://ml.azure.com/runs/neat_engine_stv9pnc0tg?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47 2. invalid local file path and folder path - invalid path but not default path ![image](https://github.com/microsoft/promptflow/assets/75061414/3bb7fa53-e91d-4e0e-86d7-07503073460a) - default path ![image](https://github.com/microsoft/promptflow/assets/75061414/e14a0d7b-126a-41c6-914b-4d716da791e2) 3. invalid data asset path https://ml.azure.com/runs/lucid_brake_dvwr49x28v?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47# ![image](https://github.com/microsoft/promptflow/assets/75061414/54d77749-6e3c-4cec-83a9-5e73e6bb26e1) # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. --------- Co-authored-by: cs_lucky <si.chen@microsoft.com>
- Loading branch information