Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In local mode, we first attempt to use the configured
document_nodes_file
if it's valid, otherwise, we fall back todocuments_folder
. In cloud mode,document_nodes_file
is used if configured, without any validity checks because we cannot check if it is a data asset. For cloud mode, both local files and data assets can be used.Local Tests:
happy path
skip split
has split:
documents_folder = "..\..\docs\reference\tools-reference"
invalid file path and folder path
Cloud Tests:
happy path (local and asset)
skip split: https://ml.azure.com/runs/tough_guava_3znwhjb9sc?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
has split: https://ml.azure.com/runs/happy_flower_kr0y3yy56z?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
skip split: https://ml.azure.com/runs/frosty_raisin_tsrhm41knv?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
has split: https://ml.azure.com/runs/neat_engine_stv9pnc0tg?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
invalid local file path and folder path
invalid data asset path
https://ml.azure.com/runs/lucid_brake_dvwr49x28v?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/workspaces/yaopfeus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47#
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines