-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'try as tutorial' link/button for docview #6666
Conversation
I would much rather that we fixt the URL |
There's a lot wrong with these pages (in addition to the link being wrong in the side docs view). I'm trying to pull some metrics to see how popular these pages are and whether it's worth it to fix them or just trash them. |
The document renderer hasn't kept up with the markdown changes to support tutorials. These don't really serve as document pages as they are almost always launched as tutorials. In the past, there was parity with viewing tutorial markdown as a page and running it as a tutorial. We're past that now. Maybe it's time to implement something like |
Okay, let me pull the usage data, and we can figure out what we want to do here based on that. |
Okay, so it looks like a significant amount of people in the last month went to these pages. So we can't kill them. @ganicke - what's the minimal amount of work we could do to update the renderer (or just manually fix a couple of the most popular tutorial docs pages)? I do think having a @Tutorialonly flag going forward would be good too. |
@Jaqster - I guess these standalone tutorials still have some longevity to them. Since they've been optimized by @kiki-lee as tutorials, I'd hate to modify them down just so they render well as doc pages. Hmm, let's see what we might do -
|
@riknoll - do you have a feel for the level of effort option 3 would be to update the docs markdown renderer? If it's too much work, then I would say option 2 sounds good if we can redirect (I don't know how people are finding these links). |
it's a decent chunk of work, but probably a good idea in the long term. i'd really like to see us unify our markdown parsing code a bit more. right now it's split between the webapp and our docs code which is why we have disparities like this. that being said, it's probably too much work for this release. we should still plan to do this at some point though. |
Okay. I just created a bug so we don't lose it for next time - #6676. Galen, you can probably just close this PR. |
Close this PR as updates to doc rendering will address the problems discussed here. |
Remove the "Try this tutorial" button/links due to malformed URL's when opened in sidedocs vs. docs view. If it's desired to keep these, then we could modify the open url logic in the render.
Erroneous URL formed from sidedocs view:
https://arcade.makecode.com/---docs#doc:#tutorial:/tutorials/chase-the-pizza
...from markdown:
RE: #6604 (comment)