fix crash when same variable is cached in multiple flyouts #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like build is failing due to recent travis update that went from ubuntu14->16.04. Updated |
|
Fixed build by pegging it to use 14 ('trusty') instead of the new one (noticed that it was possible from google/blockly#2403) |
shakao
reviewed
Jun 11, 2019
This reverts commit 138f24c, as we switched back to the previous ubuntu distro and it is no longer needed
shakao
approved these changes
Jun 11, 2019
pelikhan
reviewed
Jun 11, 2019
| 'id, "' + opt_id + '".'); | ||
| } | ||
| // The variable already exists and has the same ID. | ||
| // pxt-blockly: no error if the wrong ID is passed, as we do not allow duplicate variable names |
There was a problem hiding this comment.
does blockly have some kind of options where we could disable this check, instead of erasing it. will that be a problem when trying to keep in sync with blockly maintream?
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-arcade#980
My understanding is we don't need this crash condition, cause we already only allow a single variable per variable name (versus default blockly which can have multi variables of different types with the same name). I can look into fixing this by invalidating the cached flyouts or something if that approach is preferred, but I don't think this is an an error that really applies to us. Holding off on changing any tests till that's confirmed though.
One other thing: I needed to
npm linkblockly from pxt for my changes to apply, not sure if that's intentional (I didn't see it mentioned anywhere in the docs, can add it).