Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kata examples should be editable and runanble #591

Closed
DmitryVasilevsky opened this issue Aug 16, 2023 · 1 comment · Fixed by #1829
Closed

Kata examples should be editable and runanble #591

DmitryVasilevsky opened this issue Aug 16, 2023 · 1 comment · Fixed by #1829
Labels
bug Something isn't working katas

Comments

@DmitryVasilevsky
Copy link
Contributor

DmitryVasilevsky commented Aug 16, 2023 •
edited
Loading

Currently katas in the playground have no way to edit or run examples (in the main index file or in the answer/solution file).

To Reproduce

Open any Kata with example "multi-qubit systems" and scroll to any example (for example, Lesson: Multi-qubit systems in Q#). The code will be shown read-only without any buttons to run.

Expected behavior

Kata code examples should be editable and runnable just like the default sample in the playground.
@DmitryVasilevsky DmitryVasilevsky added bug Something isn't working needs triage katas labels Aug 16, 2023
@DmitryVasilevsky DmitryVasilevsky changed the title Kata infrastructure doesn't show editable/runable examples Kata examples should be editable and runanble Aug 16, 2023
@sezna
Copy link
Contributor

sezna commented Aug 1, 2024

@DmitryVasilevsky is this done now? It seems katas are editable now on microsoft.github.io/qsharp

This was referenced Aug 5, 2024
Closed
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
@ggridin
Add edit/run for kata examples - issue 591 (#1829)
df339be 
Add the edit/run for kata examples.
This PR closes #591

Monaco editor model should have a unique URI (with few exceptions). So,
either kata lesson ID or kata exercise ID is provided to the model. The
Editor.tsx implementation is replacing "kataExercise" parameter with
"kataSection" that contains both lesson.id and exercise.id.
The function parameter "key" is not in use and was removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working katas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add edit/run for kata examples - issue 591 ggridin/qsharp
2 participants
@sezna @DmitryVasilevsky