forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some robustness to the CI and switch to Xcode 12 #709
Merged
Merged
Changes from 82 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
8df39e1
Update RCTCxxBridge.mm
HeyImChris 4a9bcbd
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris e8d2d8b
Merge pull request #1 from microsoft/master
HeyImChris ab71c3b
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris e40c784
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 204ddb3
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris a76bcc1
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 7d85560
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 7011dc4
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris abfbabf
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 19aa189
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 8206128
make CI xcode versioning more robust to xcode12
HeyImChris 23be475
update to xcode 12.4
HeyImChris 3b2c1c7
use apple variables file
HeyImChris ea4f432
Update RCTCxxBridge.mm
HeyImChris 41fd8d4
Merge branch 'master' of https://github.com/HeyImChris/react-native-m…
HeyImChris bc002f5
add quotes
HeyImChris f01c601
switch to catalina
HeyImChris 5df978e
update pods to 10.15
HeyImChris 645ccf0
Merge branch 'master' of https://github.com/HeyImChris/react-native-m…
HeyImChris fcbb23e
make CI xcode versioning more robust to xcode12
HeyImChris 1796f80
update to xcode 12.4
HeyImChris a5204c1
use apple variables file
HeyImChris 2655ce1
add quotes
HeyImChris 976c049
switch to catalina
HeyImChris 4cf4987
update pods to 10.15
HeyImChris 63004c7
upgrade version requirements to n-2 for osx
HeyImChris b549e2b
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris e4fd236
make CI xcode versioning more robust to xcode12
HeyImChris 98ed06c
update to xcode 12.4
HeyImChris a2810b5
use apple variables file
HeyImChris 0d3ab65
add quotes
HeyImChris dfbd871
switch to catalina
HeyImChris ba3c3c2
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris 08378e7
make CI xcode versioning more robust to xcode12
HeyImChris 184a65b
update to xcode 12.4
HeyImChris 56a5b1d
use apple variables file
HeyImChris efbc5ad
add quotes
HeyImChris e45897d
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris 3a83bb8
Merge branch 'master' into xcode12
HeyImChris 547dbbc
make CI xcode versioning more robust to xcode12
HeyImChris 87018a9
update to xcode 12.4
HeyImChris f196737
use apple variables file
HeyImChris b02f85a
add quotes
HeyImChris 6449ad5
CI should run on PRs to future stable branches (#718)
acoates-ms fbe63db
Pull in header's C declaration to stop symbol mangling (#728)
HeyImChris f55a999
scroll content with animation (#725)
marty-wang 159dce1
Fix missing props on secure text input (#719)
appden 19f4a9c
Enable animated gif playback on Mac (#724)
marty-wang 915000d
Add explicit Tab support to keyboarding (#723)
HeyImChris cda139d
Fix Deadlock in RCTi18nUtil (iOS) (#733)
Saadnajmi cf5a61a
update to macOS 10.15
HeyImChris 933ff87
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris 677c467
Merge branch 'master' into xcode12
HeyImChris 1cd4f9a
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris b5610db
make CI xcode versioning more robust to xcode12
HeyImChris 2c99a1f
update to xcode 12.4
HeyImChris 95893fa
use apple variables file
HeyImChris b6be4de
add quotes
HeyImChris c6f2eb8
switch to catalina
HeyImChris 221146e
update pods to 10.15
HeyImChris d856945
upgrade version requirements to n-2 for osx
HeyImChris 100a567
make CI xcode versioning more robust to xcode12
HeyImChris 54973f6
update to xcode 12.4
HeyImChris b46db1d
use apple variables file
HeyImChris 2a5eb8c
add quotes
HeyImChris eb266fe
switch to catalina
HeyImChris 65b84b6
make CI xcode versioning more robust to xcode12
HeyImChris 156965e
update to xcode 12.4
HeyImChris 51725ed
use apple variables file
HeyImChris 2012916
add quotes
HeyImChris 29d1286
make CI xcode versioning more robust to xcode12
HeyImChris 1f75063
update to xcode 12.4
HeyImChris 2970187
use apple variables file
HeyImChris 3ad4df6
add quotes
HeyImChris ac37210
update to macOS 10.15
HeyImChris d8f7530
update to xcode 12.4
HeyImChris 22e74c4
use apple variables file
HeyImChris 06f74ba
switch to catalina
HeyImChris ff9c754
10.14
HeyImChris a583264
Merge branch 'xcode12' of https://github.com/HeyImChris/react-native-…
HeyImChris 7d43df0
CI has to run on 10.15.4 or later
HeyImChris 72c2659
fix up pod errors
HeyImChris 2fa4dd9
upgrade iphone simulator
HeyImChris ae75fb6
iphone 13
HeyImChris 99fa848
remove old post install script
HeyImChris faa49d4
iphone 8
HeyImChris 67e663b
Restore Podfile.lock to see if it fixes CI
anandrajeswaran 4d5c7b8
Restore compiler flags in TurboModuleCxx-WinRTPort
anandrajeswaran 9d9d8fa
Remove macOS arm64 build divergence
anandrajeswaran 17e61c9
Remove building all ARCHS temporarily
anandrajeswaran c3b686f
Override ONLY_ACTIVE_ARCH in release builds too
anandrajeswaran caac984
Push iOS 14 snapshots
anandrajeswaran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
# | ||
# Task Group: XCode select proper version | ||
# Task Group: Xcode select proper version | ||
# | ||
|
||
parameters: | ||
slice_name: '' | ||
xcode_version: '' | ||
|
||
steps: | ||
- bash: | | ||
sudo xcode-select --switch '/Applications/Xcode_11.2.1.app' | ||
displayName: 'Switch to XCode 11.2.1' | ||
sudo xcode-select --switch '${{ parameters.xcode_version }}' | ||
displayName: Switch Xcode version ${{ parameters.slice_name }} | ||
failOnStderr: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
variables: | ||
VmImage: macOS-10.14 | ||
VmImage: macOS-10.15 | ||
slice_name: 'Xcode_12_4' | ||
xcode_version: '/Applications/Xcode_12.4.app' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ios=>"13.0" it will make our sizes small too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should try to do that ASAP, but I'm not sure we necessarily want to diverge from upstream here. it would be weird if someone consumed this fork of react-native for x-plat support but that resulted in a different minimum supported OS than the upstream repo.
Separate of this change it might be good to try to push upstream to be more aggressive with minimum supported OS given usage trends and practical impact of size as well as work internally to see if we can override this in our consumption of react-native-macos (and in turn provide guidance to other clients who want to upgrade their minimum supported OS before we are able to get a newer version pushed to upstream)