fix: declare support for react-native 0.69 #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
tido64
force-pushed
the
tido/bump-react-native
branch
from
3a705a1 to
057a9a9
Compare
tido64
force-pushed
the
tido/bump-react-native
branch
from
057a9a9 to
3fc607f
Compare
tido64
force-pushed
the
tido/bump-react-native
branch
from
3fc607f to
aaaa791
Compare
kelset
approved these changes
Jun 13, 2022
Contributor
kelset
left a comment
kelset
left a comment
There was a problem hiding this comment.
Looks good, added a nit suggestion but feel free to proceed if you want 👍
| "peerDependencies": { | ||
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2", | ||
| "react-native": "^0.0.0-0 || 0.62 - 0.68 || 1000.0.0", | ||
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
| "react": "~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0", |
nit: since we use ~ we should just be able to use the .0 for the patch version, it will account for them all
Member
Author
There was a problem hiding this comment.
In general, we shouldn't deviate from what react-native requires. By allowing the version number to go higher, we're basically allowing some leeway in case of emergencies. I don't think we should allow users to downgrade.
Contributor
There was a problem hiding this comment.
yeah that makes sense, in that case we can go
Suggested change
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~18.0.0", |
| "mustache": "^4.0.0", | ||
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2", | ||
| "react-native": "^0.0.0-0 || 0.62 - 0.68 || 1000.0.0", | ||
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
| "react": "~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0", |
(same as above)
| peerDependencies: | ||
| react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 | ||
| react-native: ^0.0.0-0 || 0.62 - 0.68 || 1000.0.0 | ||
| react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0 | |
| react: ~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Declare support for
react-native0.69.Discussion: reactwg/react-native-releases#21
Platforms affected
Test plan