Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new initWindowsInternal() method that copies and fills in files from the given template name #12151

Closed
Tracked by #11920
jonthysell opened this issue Sep 18, 2023 · 0 comments · Fixed by #12123
Assignees
Milestone

Comments

@jonthysell
Copy link
Contributor

No description provided.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 18, 2023
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Sep 18, 2023
## Description

This PR implements a new, named template-based `react-native
init-windows` command as described by microsoft#11920.

Note, this does not change or deprecate the existing
`react-native-windows-init` / `generateWindows` infrastructure or
templates.

### Type of Change
- New feature (non-breaking change which adds functionality)

### Why

This is part of restructuring how users can add RNW support to their RN
projects.

### What

1. Creates a new `init-windows` RN CLI command that creates a new
   windows project based on a given template
2. The first CLI templates under `old/`, which are just wrappers which
   call the existing templating code in `generateWindows`

Closes microsoft#12152
Closes microsoft#12151
Closes microsoft#12150
Closes microsoft#12149
Closes microsoft#12148
Closes microsoft#12147

## Screenshots
N/A

## Testing
Ran existing tests, created base `initWindows` tests.

## Changelog
Should this change be included in the release notes: yes

Created a new `init-windows` command
@chrisglein chrisglein added enhancement Area: CLI and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 21, 2023
@chrisglein chrisglein added this to the 0.73 milestone Sep 21, 2023
jonthysell added a commit that referenced this issue Sep 21, 2023
* Create new CLI init-windows command

## Description

This PR implements a new, named template-based `react-native
init-windows` command as described by #11920.

Note, this does not change or deprecate the existing
`react-native-windows-init` / `generateWindows` infrastructure or
templates.

### Type of Change
- New feature (non-breaking change which adds functionality)

### Why

This is part of restructuring how users can add RNW support to their RN
projects.

### What

1. Creates a new `init-windows` RN CLI command that creates a new
   windows project based on a given template
2. The first CLI templates under `old/`, which are just wrappers which
   call the existing templating code in `generateWindows`

Closes #12152
Closes #12151
Closes #12150
Closes #12149
Closes #12148
Closes #12147

## Screenshots
N/A

## Testing
Ran existing tests, created base `initWindows` tests.

## Changelog
Should this change be included in the release notes: yes

Created a new `init-windows` command

* fix generateWrapper

* remove sample apps package.json

* update yarn.lock

* Rename old templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants