Create new CLI init-windows command
#12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
force-pushed
the
initWindows
branch
3 times, most recently
from
97cb7c5
to
584426c
Compare
## Description This PR implements a new, named template-based `react-native init-windows` command as described by microsoft#11920. Note, this does not change or deprecate the existing `react-native-windows-init` / `generateWindows` infrastructure or templates. ### Type of Change - New feature (non-breaking change which adds functionality) ### Why This is part of restructuring how users can add RNW support to their RN projects. ### What 1. Creates a new `init-windows` RN CLI command that creates a new windows project based on a given template 2. The first CLI templates under `old/`, which are just wrappers which call the existing templating code in `generateWindows` Closes microsoft#12152 Closes microsoft#12151 Closes microsoft#12150 Closes microsoft#12149 Closes microsoft#12148 Closes microsoft#12147 ## Screenshots N/A ## Testing Ran existing tests, created base `initWindows` tests. ## Changelog Should this change be included in the release notes: yes Created a new `init-windows` command
jonthysell
force-pushed
the
initWindows
branch
from
85f849c
to
5b05571
Compare
jonthysell
changed the title
init-windows commandinit-windows command
AgneLukoseviciute
approved these changes
Sep 21, 2023
TatianaKapos
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new, named template-based
react-native init-windowscommand as described by #11920.Note, this does not change or deprecate the existing
react-native-windows-init/generateWindowsinfrastructure or templates.Type of Change
Why
This is part of restructuring how users can add RNW support to their RN projects.
What
init-windowsRN CLI command that creates a new windows project based on a given templateold/, which are just wrappers which call the existing templating code ingenerateWindowsCloses #12152
Closes #12151
Closes #12150
Closes #12149
Closes #12148
Closes #12147
Screenshots
N/A
Testing
Ran existing tests, created base
initWindowstests.Changelog
Should this change be included in the release notes: yes
Created a new
init-windowscommandMicrosoft Reviewers: Open in CodeFlow