[CodeQL] Patch fmt/core.h, folly/ConstexprMath.h, and loadBundleFromServer.js #13281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
changed the title
jonthysell
approved these changes
May 29, 2024
| } else { | ||
| // [Windows #12704 - CodeQL patch] | ||
| // eslint-disable-next-line no-eval | ||
| eval(body); // CodeQL [js/eval-usage] Debug only. Developer inner loop. |
Contributor
There was a problem hiding this comment.
Do we have a PR to get this upstreamed?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patching fmt CodeQL issues until upstream fix is published and we can consume it. #12702, #12703, #12704
Type of Change
Fmt, folly, and upstream patches
Why
We don't know when fmt will publish next.
What
Fixed fmt patching. Forked fmt/core.h, folly/ConstexprMath.h and loadBundleFromServer.js with fixes.
Testing
Confirmed node_modules fmt core.h version gets overwritten by the one in TEMP_UntilFollyUpdate on build
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow