Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: disable confirm button when no changes were made #1509

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

romanlutz
Copy link
Contributor

Description

This PR disables the confirm button in the feature configuration flyout until actual changes were made to the previous selection:

Dashboard.-.Google.Chrome.2022-06-20.22-10-44.mp4

Previously, the button wouldn't get disabled unless we select more than 2 features.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from xuke444 as a code owner June 21, 2022 02:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1509 (e9310d1) into main (e71bc37) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         108      108           
  Lines        5108     5108           
=======================================
  Hits         4458     4458           
  Misses        650      650           
Flag Coverage Δ
unittests 87.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71bc37...e9310d1. Read the comment docs.

1 similar comment
@romanlutz romanlutz merged commit 46d1ab7 into main Jun 22, 2022
@romanlutz romanlutz deleted the romanlutz/disable_confirm_button branch June 22, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants