Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: disable confirm button when no changes were made #1509

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Model overview: disable confirm button when no changes were made #1509

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52d2f31
add condition to disable confirm button if no changes were made
romanlutz Jun 21, 2022
64d6611
lintfix
romanlutz Jun 21, 2022
2fbaa70
Merge branch 'main' into romanlutz/disable_confirm_button
romanlutz Jun 21, 2022
da4940e
adjustments as recommended in pr
romanlutz Jun 21, 2022
96c5026
lintfix
romanlutz Jun 21, 2022
e9310d1
Merge branch 'main' into romanlutz/disable_confirm_button
romanlutz Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions ...nt/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FeatureConfigurationFlyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ export class FeatureConfigurationFlyout extends React.Component<
this.state = {
items: [],
newlySelectedFeatures: this.props.selectedFeatures,
newNumberOfContinuousFeatureBins: this.props.numberOfContinuousFeatureBins
newNumberOfContinuousFeatureBins: {
...this.props.numberOfContinuousFeatureBins
}
};
this.updateSelection();
}
Expand All @@ -98,7 +100,12 @@ export class FeatureConfigurationFlyout extends React.Component<
// At other times we can't update with props since they may be outdated compared to the state.
if (this.props.isOpen && !prevProps.isOpen) {
this.setState(
{ newlySelectedFeatures: this.props.selectedFeatures },
{
newlySelectedFeatures: this.props.selectedFeatures,
newNumberOfContinuousFeatureBins: {
...this.props.numberOfContinuousFeatureBins
}
},
() => {
this.updateSelection();
}
Expand Down Expand Up @@ -181,6 +188,25 @@ export class FeatureConfigurationFlyout extends React.Component<

private onRenderFooterContent = () => {
const tooManyFeaturesSelected = this._selection.getSelectedCount() > 2;
// check that feature selection has not changed
const featureSelectionChanged =
this.props.selectedFeatures.length !==
this.state.newlySelectedFeatures.length ||
this.props.selectedFeatures.some(
(feature, featureIndex) =>
this.state.newlySelectedFeatures[featureIndex] !== feature
);
// check that number of continuous feature bins for the selected features has not changed
const continuousFeatureBinningChanged =
this.state.newlySelectedFeatures.some((_, featureIndex) => {
const newNumberOfBins =
this.state.newNumberOfContinuousFeatureBins[featureIndex] ??
defaultNumberOfContinuousFeatureBins;
const prevNumberOfBins =
this.props.numberOfContinuousFeatureBins[featureIndex] ??
defaultNumberOfContinuousFeatureBins;
return newNumberOfBins !== prevNumberOfBins;
});
return (
<Stack tokens={{ childrenGap: "10px" }}>
{tooManyFeaturesSelected && (
Expand All @@ -195,7 +221,10 @@ export class FeatureConfigurationFlyout extends React.Component<
<PrimaryButton
onClick={this.onConfirm}
text={localization.ModelAssessment.ModelOverview.chartConfigConfirm}
disabled={tooManyFeaturesSelected}
disabled={
tooManyFeaturesSelected ||
(!featureSelectionChanged && !continuousFeatureBinningChanged)
}
/>
<DefaultButton
onClick={this.props.onDismissFlyout}
Expand Down