Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[responsibleai]: Add tests for classification outcome (multiclass) and regression error #1662

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 22, 2022

Porting over the tests from test_cohort_filter.py into cohort tests for responsibleai.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…d regression error

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #1662 (e62c25b) into main (611ac56) will decrease coverage by 3.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
- Coverage   89.04%   85.61%   -3.44%     
==========================================
  Files         105       58      -47     
  Lines        5534     3017    -2517     
==========================================
- Hits         4928     2583    -2345     
+ Misses        606      434     -172     
Flag Coverage Δ
unittests 85.61% <ø> (-3.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponsibleai/databalanceanalysis/balance_measures.py
responsibleai/responsibleai/_tools/__init__.py
...ponsibleai/responsibleai/_tools/causal/__init__.py
responsibleai/responsibleai/_data_validations.py
responsibleai/responsibleai/_internal/constants.py
...sibleai/responsibleai/_tools/shared/base_result.py
...tabalanceanalysis/distribution_balance_measures.py
...i/responsibleai/managers/error_analysis_manager.py
...onsibleai/responsibleai/managers/causal_manager.py
...i/responsibleai/managers/counterfactual_manager.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) August 24, 2022 19:01
@gaugup gaugup disabled auto-merge August 24, 2022 23:26
@gaugup gaugup enabled auto-merge (squash) August 24, 2022 23:26
@gaugup gaugup disabled auto-merge August 24, 2022 23:27
@gaugup gaugup merged commit 873ff44 into main Aug 24, 2022
@gaugup gaugup deleted the gaugup/PortOverCohortFilteringTestys branch August 24, 2022 23:27
jamesbchao pushed a commit to jamesbchao/responsible-ai-toolbox that referenced this pull request Aug 29, 2022
# This is the 1st commit message:

table view and initial flyout

# The commit message microsoft#2 will be skipped:

# [responsibleai]: Add tests for classification outcome (multiclass) and regression error (microsoft#1662)
#
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
# 
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

# The commit message microsoft#3 will be skipped:

# fix nlp-feature-extractors release by renaming requirements file (microsoft#1670)
#

# The commit message microsoft#4 will be skipped:

# add missing positive negative words csv file to attribute extractors (microsoft#1671)
#
jamesbchao pushed a commit to jamesbchao/responsible-ai-toolbox that referenced this pull request Aug 29, 2022
# This is the 1st commit message:

table view and initial flyout

# The commit message microsoft#2 will be skipped:

# [responsibleai]: Add tests for classification outcome (multiclass) and regression error (microsoft#1662)
#
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
# 
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

# The commit message microsoft#3 will be skipped:

# fix nlp-feature-extractors release by renaming requirements file (microsoft#1670)
#

# The commit message microsoft#4 will be skipped:

# add missing positive negative words csv file to attribute extractors (microsoft#1671)
#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants