Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing positive negative words csv file to attribute extractors #1671

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Add missing positive negative words csv file to attribute extractors in nlp-feature-extractors package.
Note that instead of adding the file to source, I just download it using fetch_dataset function from rai_utils.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #1671 (4002f03) into main (5de62b2) will decrease coverage by 3.43%.
The diff coverage is n/a.

❗ Current head 4002f03 differs from pull request most recent head bbdd508. Consider uploading reports for the commit bbdd508 to get more accurate results

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
- Coverage   89.04%   85.61%   -3.44%     
==========================================
  Files         105       58      -47     
  Lines        5534     3017    -2517     
==========================================
- Hits         4928     2583    -2345     
+ Misses        606      434     -172     
Flag Coverage Δ
unittests 85.61% <ø> (-3.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/_tools/shared/base_result.py
...onsibleai/responsibleai/managers/causal_manager.py
...eai/responsibleai/databalanceanalysis/constants.py
...nsibleai/databalanceanalysis/data_balance_utils.py
responsibleai/responsibleai/_data_validations.py
responsibleai/responsibleai/_config/__init__.py
...onsibleai/_tools/shared/attribute_serialization.py
...i/responsibleai/managers/counterfactual_manager.py
responsibleai/responsibleai/managers/__init__.py
...leai/responsibleai/databalanceanalysis/__init__.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-neg-pos-count branch from c04b3f2 to 4002f03 Compare August 25, 2022 21:51
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-neg-pos-count branch from 4002f03 to bbdd508 Compare August 25, 2022 21:52
2 similar comments
@imatiach-msft imatiach-msft merged commit 77b295a into main Aug 26, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-neg-pos-count branch August 26, 2022 16:33
jamesbchao pushed a commit to jamesbchao/responsible-ai-toolbox that referenced this pull request Aug 29, 2022
# This is the 1st commit message:

table view and initial flyout

# The commit message microsoft#2 will be skipped:

# [responsibleai]: Add tests for classification outcome (multiclass) and regression error (microsoft#1662)
#
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
# 
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

# The commit message microsoft#3 will be skipped:

# fix nlp-feature-extractors release by renaming requirements file (microsoft#1670)
#

# The commit message microsoft#4 will be skipped:

# add missing positive negative words csv file to attribute extractors (microsoft#1671)
#
jamesbchao pushed a commit to jamesbchao/responsible-ai-toolbox that referenced this pull request Aug 29, 2022
# This is the 1st commit message:

table view and initial flyout

# The commit message microsoft#2 will be skipped:

# [responsibleai]: Add tests for classification outcome (multiclass) and regression error (microsoft#1662)
#
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
# 
# Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

# The commit message microsoft#3 will be skipped:

# fix nlp-feature-extractors release by renaming requirements file (microsoft#1670)
#

# The commit message microsoft#4 will be skipped:

# add missing positive negative words csv file to attribute extractors (microsoft#1671)
#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants