Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused definitions, commented out code, etc. #1876

Merged
merged 5 commits into from
Jan 6, 2023

Conversation

romanlutz
Copy link
Contributor

Description

Title says it all. Just a small cleanup.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #1876 (30c8145) into main (64bb016) will decrease coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   90.64%   90.11%   -0.53%     
==========================================
  Files          46      112      +66     
  Lines        1881     5889    +4008     
==========================================
+ Hits         1705     5307    +3602     
- Misses        176      582     +406     
Flag Coverage Δ
unittests 90.11% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/error_analysis_dashboard.py 72.41% <0.00%> (ø)
.../databalanceanalysis/aggregate_balance_measures.py 92.85% <0.00%> (ø)
...ponsibleai/responsibleai/rai_insights/constants.py 100.00% <0.00%> (ø)
...iwidgets/raiwidgets/explanation_dashboard_input.py 59.85% <0.00%> (ø)
...nsibleai/databalanceanalysis/data_balance_utils.py 100.00% <0.00%> (ø)
...onsibleai/_tools/shared/attribute_serialization.py 95.94% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/causal/__init__.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/error_handling.py 100.00% <0.00%> (ø)
...ai/responsibleai/_tools/error_analysis/__init__.py 100.00% <0.00%> (ø)
...sponsibleai/responsibleai/rai_insights/__init__.py 100.00% <0.00%> (ø)
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@romanlutz romanlutz enabled auto-merge (squash) January 4, 2023 18:30
@romanlutz romanlutz merged commit 2e525a6 into main Jan 6, 2023
@romanlutz romanlutz deleted the romanlutz/remove_unused branch January 6, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants