Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused definitions, commented out code, etc. #1876

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Remove unused definitions, commented out code, etc. #1876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
afce281
remove unused definitions, commented out code, etc.
romanlutz Jan 4, 2023
dc6d78b
Merge branch 'main' into romanlutz/remove_unused
romanlutz Jan 5, 2023
6266ed9
Merge branch 'main' into romanlutz/remove_unused
romanlutz Jan 5, 2023
2d7fdd0
Merge branch 'main' into romanlutz/remove_unused
romanlutz Jan 5, 2023
30c8145
Merge branch 'main' into romanlutz/remove_unused
romanlutz Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libs/core-ui/src/lib/Cohort/CohortList/CohortListPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { cohortListStyles } from "./CohortList.styles";
export interface ICohortListPanelProps {
isOpen: boolean;
cohorts: ErrorCohort[];
// hostId: string
onDismiss: () => void;
onEditCohortClick: (editedCohort: ErrorCohort) => void;
}
Expand Down
11 changes: 0 additions & 11 deletions libs/dataset-explorer/src/lib/ChartView/utils/DatasetExplorerTab.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import {
} from "@responsible-ai/core-ui";

export interface IDatasetExplorerTabStyles {
boldText: IStyle;
callout: IStyle;
chartContainer: IStyle;
chartEditorButton: IStyle;
chartWithAxes: IStyle;
Expand Down Expand Up @@ -51,15 +49,6 @@ export const datasetExplorerTabStyles: () => IProcessedStyleSet<IDatasetExplorer
() => {
const theme = getTheme();
return mergeStyleSets<IDatasetExplorerTabStyles>({
boldText: {
fontWeight: "600",
paddingBottom: "5px"
},
callout: {
backgroundColor: theme.semanticColors.bodyBackground,
padding: "10px 20px",
width: "200px"
},
chart: {
marginBottom: "40px",
width: "100%"
Expand Down
10 changes: 0 additions & 10 deletions libs/dataset-explorer/src/lib/DataBalanceView/DataBalanceTab.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ import {
IProcessedStyleSet,
getTheme
} from "@fluentui/react";
import { descriptionMaxWidth } from "@responsible-ai/core-ui";

export interface IDataBalanceTabStyles {
boldText: IStyle;
callout: IStyle;
dropdownLongWidth: IStyle;
dropdownMedWidth: IStyle;
infoWithText: IStyle;
page: IStyle;
}

Expand All @@ -25,19 +22,12 @@ export const dataBalanceTabStyles: () => IProcessedStyleSet<IDataBalanceTabStyle
boldText: {
fontWeight: 600
},
callout: {
margin: "-18px 0 0 0"
},
dropdownLongWidth: {
dropdown: { width: 200 }
},
dropdownMedWidth: {
dropdown: { width: 150 }
},
infoWithText: {
maxWidth: descriptionMaxWidth,
width: "100%"
},
page: {
color: theme.semanticColors.bodyText,
height: "100%",
Expand Down
25 changes: 1 addition & 24 deletions libs/model-assessment/src/lib/ModelAssessmentDashboard/ModelAssessmentDashboard.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,16 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import {
mergeStyleSets,
IStyle,
IProcessedStyleSet,
getTheme
} from "@fluentui/react";
import { mergeStyleSets, IStyle, IProcessedStyleSet } from "@fluentui/react";

export interface IModelAssessmentDashboardStyles {
page: IStyle;
section: IStyle;
buttonSection: IStyle;
sectionHeader: IStyle;
mainContent: IStyle;
}

export const modelAssessmentDashboardStyles: () => IProcessedStyleSet<IModelAssessmentDashboardStyles> =
() => {
const theme = getTheme();
return mergeStyleSets<IModelAssessmentDashboardStyles>({
buttonSection: {
textAlign: "center"
},
mainContent: {
height: "100%",
overflowY: "scroll",
Expand All @@ -37,17 +25,6 @@ export const modelAssessmentDashboardStyles: () => IProcessedStyleSet<IModelAsse
}
},
width: "100%"
},
section: {
textAlign: "left"
},
sectionHeader: {
color: theme.semanticColors.bodyText,
selectors: {
"@media screen and (min-width: 1024px)": {
padding: "16px 24px 16px 40px"
}
}
}
});
};