Dataset explorer: Propagate number of bins to SDK backend API #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
romanlutz
reviewed
Feb 4, 2023
libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts
Show resolved
Hide resolved
…BoxChartConfig.ts Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…getBarOrBoxChartConfig.ts" This reverts commit a8b2e42.
vinuthakaranth
approved these changes
Feb 6, 2023
RubyZ10
approved these changes
Feb 6, 2023
1 similar comment
gaugup
added a commit
that referenced
this pull request
Feb 7, 2023
* Dataset explorer: Propagate number of bins to SDK backend API Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Revert "Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts" This reverts commit a8b2e42. --------- Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
gaugup
added a commit
that referenced
this pull request
Feb 7, 2023
* Add more test helper functions in rai_test_utils Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Migrate responsibleai tests to use utilities in rai_test_utils - Part 1 (#1937) * Migrate responsibleai tests to use utilities in rai_test_utils - Part 1 Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Add create_cancer_data Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * fix Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> --------- Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Fix bubble chart render issue due to exception in `SidePanel` (#1941) Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * fixing strings (#1943) * Dataset explorer: Propagate number of bins to SDK backend API (#1940) * Dataset explorer: Propagate number of bins to SDK backend API Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Revert "Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts" This reverts commit a8b2e42. --------- Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Add tests Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> --------- Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we sent a fixed number of bins (5) to SDK to compute bar/box plots. Now sending the configurable value from UI.
Checklist