Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improving several error strings #1943

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

romanlutz
Copy link
Contributor

Description

Other than a couple of missing whitespaces (due to line wrap) this PR contains only small changes to add articles, improve grammar, etc.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0130b45). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 806b277 differs from pull request most recent head e369705. Consider uploading reports for the commit e369705 to get more accurate results

@@           Coverage Diff           @@
##             main    #1943   +/-   ##
=======================================
  Coverage        ?   93.23%           
=======================================
  Files           ?       95           
  Lines           ?     4701           
  Branches        ?        0           
=======================================
  Hits            ?     4383           
  Misses          ?      318           
  Partials        ?        0           
Flag Coverage Δ
unittests 93.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 92.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@romanlutz romanlutz enabled auto-merge (squash) February 6, 2023 18:13
@romanlutz romanlutz merged commit 7ef0054 into main Feb 6, 2023
@romanlutz romanlutz deleted the romanlutz/string_improvements branch February 6, 2023 20:15
gaugup pushed a commit that referenced this pull request Feb 7, 2023
gaugup added a commit that referenced this pull request Feb 7, 2023
* Add more test helper functions in rai_test_utils

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1 (#1937)

* Migrate responsibleai tests to use utilities in rai_test_utils - Part 1

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Add create_cancer_data

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* fix

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

---------

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>

* Fix bubble chart render issue due to exception in `SidePanel` (#1941)

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* fixing strings (#1943)

* Dataset explorer: Propagate number of bins to SDK backend API (#1940)

* Dataset explorer: Propagate number of bins to SDK backend API

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts

Co-authored-by: Roman Lutz <romanlutz13@gmail.com>

* Revert "Update libs/dataset-explorer/src/lib/ChartView/LargeDataView/getBarOrBoxChartConfig.ts"

This reverts commit a8b2e42.

---------

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>

* Add tests

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

---------

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants