Forecasting: restrict transformation names to 50 chars #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaugup
approved these changes
Feb 22, 2023
hawestra
reviewed
Feb 22, 2023
libs/forecasting/src/lib/ForecastingDashboard/Controls/TransformationCreationDialog.tsx
Show resolved
Hide resolved
hawestra
approved these changes
Feb 22, 2023
libs/forecasting/src/lib/ForecastingDashboard/Controls/TransformationCreationDialog.tsx
Outdated
Show resolved
Hide resolved
imatiach-msft
approved these changes
Feb 22, 2023
…olbox into romanlutz/transformation_name_max_length
…thub.com/microsoft/responsible-ai-toolbox into romanlutz/transformation_name_max_length
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing arbitrarily long transformation names can cause all sorts of issues. To prevent that, this PR sets the max length to 50 characters. We're also no longer showing the error message from the start but rather upon the first change that makes the name invalid.
When opening a new dialog:
After entering a name and erasing it:
When there's a name collision:
When the char limit of 50 is exceeded:
Checklist