Forecasting: validate characters for name field in transformation creation dialog #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
changed the title
1 similar comment
|
should there be a string length check ? or is this already existing ? |
hawestra
approved these changes
Feb 24, 2023
That was added in #1981 🙂 It's an earlier check so it doesn't need to be part of the function with the regex. |
imatiach-msft
approved these changes
Feb 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds input validation for the name field in the transformation creation dialog. Length validation already exists, so this only adds character validation.
If you write a name and fully erase it:
If you enter invalid characters:
Checklist