Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Grafana dashboards for Hubble control plane and update doc #811

Closed
SRodi opened this issue Oct 4, 2024 · 1 comment
Closed

Fix Grafana dashboards for Hubble control plane and update doc #811

SRodi opened this issue Oct 4, 2024 · 1 comment
Assignees
@SRodi
Labels
area/metrics control-plane/hubble good first issue Good for newcomers type/fix Fixes something

Comments

@SRodi
Copy link
Member

SRodi commented Oct 4, 2024 •
edited
Loading

Issue

The Hubble control plane Grafana dashboards are currently broken for node selection and require similar fix applied as part of #797

Goal

  1. Fix dashboards dns.json and pod-flows-namespace.json
  2. update the docs with an example of a Hubble flow dashboard

DoD

  1. install retina hubble control plane
  2. install prometheus with the values.yaml created as part of Create Prometheus values.yaml with additionalScrapeConfigs for Hubble control plane #810
  3. port-forward Grafana
  4. import (fixed) hubble Grafana dashboards
  5. validate

Dependency
@SRodi SRodi self-assigned this Feb 12, 2025
This was referenced Feb 12, 2025
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2025
@SRodi
fix(grafana): Fix dashboard Hubble pod-flow-workload dashboard (#1341)
764d86b 
# Description

* fix pod-flow-workload Hubble dashboard

## Related Issue

#811 

## Checklist

- [x] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [x] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

![Screenshot 2025-02-12
115154](https://github.com/user-attachments/assets/186a42cb-2b45-45a8-b6c1-8ec6dba4d593)

![Screenshot 2025-02-12
115213](https://github.com/user-attachments/assets/386ae58f-6bc1-4f6f-b723-d7d1bad73e04)

## Additional Notes

Dashboard `pod-flows-namespace.json` is still broken. Need someone to
investigate how to fix it (I'll link the relevant GH issue here).

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
@alexcastilio alexcastilio mentioned this issue Feb 19, 2025
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2025
@alexcastilio
fix(dashboard): fix hubble dashboards: dns.json, pod-flows-namespace.…
70aff2f 
…json (#1369)

# Description

Fix hubble dashboards: dns.json, pod-flows-namespace.json
Adjust dashboards cluster.json and pod-flows-workload.json for
consistency on variables

## Related Issue

#811 

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed
dns.json:

![image](https://github.com/user-attachments/assets/9b7e638c-20ab-4f99-bd18-511490018a25)

![image](https://github.com/user-attachments/assets/0cd9fd33-e01d-4dd7-b525-75e2dc9a1a07)
pod-flows-namespace.json:

![image](https://github.com/user-attachments/assets/d3c9808c-5c1f-4214-ac52-6322ea2bdaf1)

![image](https://github.com/user-attachments/assets/eec743fa-8373-4bbd-87c1-29d7e1f3acf5)

![image](https://github.com/user-attachments/assets/d80a637e-9402-43dd-abc1-bceb26859541)

![image](https://github.com/user-attachments/assets/8eb2a0b0-0347-431c-9d57-53f44524baf3)



## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
@alexcastilio
Copy link
Contributor

There's already an example of dashboard in the docs at: https://retina.sh/docs/Installation/grafana#retina-dashboards

Adding another example would not add much value as it would be redundant, so doc page was not udpated.

BeegiiK pushed a commit to BeegiiK/retina that referenced this issue Feb 28, 2025
@alexcastilio @BeegiiK
fix(dashboard): fix hubble dashboards: dns.json, pod-flows-namespace.…
e2652e4 
…json (microsoft#1369)

# Description

Fix hubble dashboards: dns.json, pod-flows-namespace.json
Adjust dashboards cluster.json and pod-flows-workload.json for
consistency on variables

## Related Issue

microsoft#811 

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed
dns.json:

![image](https://github.com/user-attachments/assets/9b7e638c-20ab-4f99-bd18-511490018a25)

![image](https://github.com/user-attachments/assets/0cd9fd33-e01d-4dd7-b525-75e2dc9a1a07)
pod-flows-namespace.json:

![image](https://github.com/user-attachments/assets/d3c9808c-5c1f-4214-ac52-6322ea2bdaf1)

![image](https://github.com/user-attachments/assets/eec743fa-8373-4bbd-87c1-29d7e1f3acf5)

![image](https://github.com/user-attachments/assets/d80a637e-9402-43dd-abc1-bceb26859541)

![image](https://github.com/user-attachments/assets/8eb2a0b0-0347-431c-9d57-53f44524baf3)



## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SRodi SRodi

Labels
area/metrics control-plane/hubble good first issue Good for newcomers type/fix Fixes something
Projects
Retina Triage Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcastilio @SRodi