Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): fix hubble dashboards: dns.json, pod-flows-namespace.json #1369

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

alexcastilio
Copy link
Contributor

@alexcastilio alexcastilio commented Feb 18, 2025

Description

Fix hubble dashboards: dns.json, pod-flows-namespace.json
Adjust dashboards cluster.json and pod-flows-workload.json for consistency on variables

Related Issue

#811

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

dns.json:
image
image
pod-flows-namespace.json:
image
image
image
image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@alexcastilio alexcastilio requested a review from a team as a code owner February 18, 2025 16:59
…json

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
@alexcastilio alexcastilio force-pushed the alexcastilio/hubble-dashboard branch from 0d0e7b0 to 9aa9aa6 Compare February 19, 2025 10:04
Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexcastilio alexcastilio added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 70aff2f Feb 19, 2025
28 checks passed
@alexcastilio alexcastilio deleted the alexcastilio/hubble-dashboard branch February 19, 2025 12:01
BeegiiK pushed a commit to BeegiiK/retina that referenced this pull request Feb 28, 2025
…json (microsoft#1369)

# Description

Fix hubble dashboards: dns.json, pod-flows-namespace.json
Adjust dashboards cluster.json and pod-flows-workload.json for
consistency on variables

## Related Issue

microsoft#811 

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed
dns.json:

![image](https://github.com/user-attachments/assets/9b7e638c-20ab-4f99-bd18-511490018a25)

![image](https://github.com/user-attachments/assets/0cd9fd33-e01d-4dd7-b525-75e2dc9a1a07)
pod-flows-namespace.json:

![image](https://github.com/user-attachments/assets/d3c9808c-5c1f-4214-ac52-6322ea2bdaf1)

![image](https://github.com/user-attachments/assets/eec743fa-8373-4bbd-87c1-29d7e1f3acf5)

![image](https://github.com/user-attachments/assets/d80a637e-9402-43dd-abc1-bceb26859541)

![image](https://github.com/user-attachments/assets/8eb2a0b0-0347-431c-9d57-53f44524baf3)



## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

---------

Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants