Remove optional dependency and have rush install skip optional #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qz2017
approved these changes
May 5, 2017
octogonz
reviewed
May 5, 2017
| @@ -180,7 +176,7 @@ export default class InstallManager { | |||
| console.log(os.EOL + 'Running "npm install" in ' + npmToolFolder); | |||
|
|
|||
| // NOTE: Here we use whatever version of NPM we happen to find in the PATH | |||
| Utilities.executeCommandWithRetry('npm', ['install'], MAX_INSTALL_ATTEMPTS, npmToolFolder); | |||
| Utilities.executeCommandWithRetry('npm', ['install', '--no-optional'], MAX_INSTALL_ATTEMPTS, npmToolFolder); | |||
There was a problem hiding this comment.
'--no-optional' [](start = 59, length = 15)
This was the outcome of a long discussion. It will seem odd to someone who's reading the code and trying to understand why we chose that behavior.
Could you add some code comments explaining this design decision?
There was a problem hiding this comment.
Also, what was the outcome of your shrinkwrap-diffing experiment?
In reply to: 115061095 [](ancestors = 115061095)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.