[rush] Install optional dependencies, except when using npm<5.0.0 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elliottsj
force-pushed
the
rush-install-optional
branch
from
fb0a8ae to
03e8c54
Compare
|
I've tested this change on macOS, using npm@4.6.1, npm@6.4.1, pnpm@2.16.3, and yarn@1.12.0. Haven't tested on Windows (and don't currently have a Windows machine set up for Node.js development), so any help there is appreciated. |
elliottsj
commented
Oct 16, 2018
| @@ -975,15 +958,34 @@ export class InstallManager { | |||
| */ | |||
| private _pushConfigurationArgs(args: string[], options: IInstallManagerOptions): void { | |||
| if (this._rushConfiguration.packageManager === 'npm') { | |||
| args.push('--no-optional'); | |||
| if (semver.lt(this._rushConfiguration.packageManagerToolVersion, '5.0.0')) { | |||
| // NOTE: | |||
There was a problem hiding this comment.
I kept this comment (which was originally added in #175), reworded it a bit, and added a couple useful links. lmk if I should change anything else here.
|
This fix was released with Rush 5.3.4 |
octogonz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #761
With this change, optional dependencies are no longer ignored, and instead are written to the package manager's (npm/pnpm/yarn) respective lockfile. This allows optional dependencies such as fsevents to be installed on supported systems (e.g. macOS), but remain uninstalled on unsupported systems (e.g. Windows).
For more info about this change, see #761 (comment)