-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint-plugin] Support ESLint 8 #3057
Conversation
…user/danade/eslint8
Can you add a project that continues to test ESLint 7? |
IIRC you mentioned that |
common/changes/@rushstack/eslint-config/user-danade-eslint8_2021-12-01-20-53.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/heft-web-rig/user-danade-eslint8_2021-12-01-20-54.json
Outdated
Show resolved
Hide resolved
I would prefer not to go that route. The change on the eslint-plugin-promise is relatively minor, just taking a while to go through... on our side, we currently only consume one rule, and it's a pretty simple one (confusing resolve and reject callbacks). Patching for eslint to add a new feature is one thing... patching a rules package where we only consume 1 rule seems excessive. Especially since |
@iclanton I added a small test project, could you take a look to make sure that it's sufficient? |
Summary
Updates the Rushstack repo to support and use ESLint v8 for linting.
Fixes #2890
cc @lukashass
Details
There are some aspects to this upgrade that deserve to be called out:
@rushstack/tree-pattern
is temporarily remaining oneslint@7.30.0
. This is due to it's dependency on an older version of@rushstack/eslint-config
/@rushstack/eslint-plugin
since it consumes these packages as cyclic dependencies. Once the new packages are published and the cyclic dependencies are bumped, this project should be able to be updated to8.3.0
and have the common-versions.json changes removed.@rushstack/eslint-config
temporarily disableseslint-plugin-promise
rules (of which there was only one). This is required since the package does not yet support ESLint v8 (see this issue: Support ESLint 8.x eslint-community/eslint-plugin-promise#218).How it was tested
Build while consuming the new version of ESLint and the updated config/plugin in dependent projects.