Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] Support ESLint 8 #3057

Merged
merged 17 commits into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/heft/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@rushstack/heft": "0.42.3",
"@rushstack/heft-node-rig": "1.2.32",
"@types/argparse": "1.0.38",
"@types/eslint": "7.2.0",
"@types/eslint": "8.2.0",
"@types/glob": "7.1.1",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
Expand Down
2 changes: 1 addition & 1 deletion apps/heft/src/plugins/TypeScriptPlugin/Eslint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class Eslint extends LinterBase<TEslint.ESLint.LintResult> {
'Heft requires ESLint 7 or newer. Your ESLint version is too old:\n' + this._eslintPackagePath
);
}
if (majorVersion > 7) {
if (majorVersion > 8) {
// We don't use writeWarningLine() here because, if the person wants to take their chances with
// a newer ESLint release, their build should be allowed to succeed.
this._terminal.writeLine(
Expand Down
8 changes: 4 additions & 4 deletions apps/rush-lib/src/logic/taskRunner/BaseBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,21 @@ export abstract class BaseBuilder {
/**
* Name of the task definition.
*/
abstract readonly name: string;
public abstract readonly name: string;
D4N14L marked this conversation as resolved.
Show resolved Hide resolved

/**
* This flag determines if the task is allowed to be skipped if up to date.
*/
abstract isSkipAllowed: boolean;
public abstract isSkipAllowed: boolean;

/**
* Assigned by execute(). True if the build script was an empty string. Operationally an empty string is
* like a shell command that succeeds instantly, but e.g. it would be odd to report build time statistics for it.
*/
abstract hadEmptyScript: boolean;
public abstract hadEmptyScript: boolean;

/**
* Method to be executed for the task.
*/
abstract executeAsync(context: IBuilderContext): Promise<TaskStatus>;
public abstract executeAsync(context: IBuilderContext): Promise<TaskStatus>;
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-basic-tutorial/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@rushstack/heft-jest-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
}
}
2 changes: 1 addition & 1 deletion build-tests-samples/heft-node-jest-tutorial/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"@rushstack/heft-jest-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/react": "16.9.45",
"@types/webpack-env": "1.13.0",
"css-loader": "~4.2.1",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"heft-storybook-react-tutorial-storykit": "workspace:*",
"html-webpack-plugin": "~5.5.0",
"react-dom": "~16.13.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@types/react-dom": "16.9.8",
"@types/webpack-env": "1.13.0",
"css-loader": "~4.2.1",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"html-webpack-plugin": "~5.5.0",
"react": "~16.13.1",
"react-dom": "~16.13.1",
Expand Down
2 changes: 1 addition & 1 deletion build-tests-samples/packlets-tutorial/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-action-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-01/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@rushstack/heft": "workspace:*",
"@types/node": "12.20.24",
"@types/tapable": "1.0.6",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
}
}
2 changes: 1 addition & 1 deletion build-tests/heft-example-plugin-02/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"heft-example-plugin-01": "workspace:*",
"typescript": "~4.4.2"
}
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-fastify-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@rushstack/heft": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-jest-reporters-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/heft": "workspace:*",
"@rushstack/heft-jest-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2",
"@jest/reporters": "~25.4.0",
"@jest/types": "~25.4.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@rushstack/heft-jest-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"heft-example-plugin-01": "workspace:*",
"heft-example-plugin-02": "workspace:*",
"tslint": "~5.20.1",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-node-everything-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@rushstack/heft-jest-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"heft-example-plugin-01": "workspace:*",
"heft-example-plugin-02": "workspace:*",
"tslint": "~5.20.1",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-parameter-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@rushstack/eslint-config": "workspace:*",
"@rushstack/heft": "workspace:*",
"@types/node": "12.20.24",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"typescript": "~4.4.2"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-sass-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@types/webpack-env": "1.13.0",
"autoprefixer": "~9.8.0",
"css-loader": "~4.2.1",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"html-webpack-plugin": "~5.5.0",
"node-sass": "6.0.1",
"postcss": "7.0.32",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-typescript-composite-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@types/heft-jest": "1.0.1",
"@types/webpack-env": "1.13.0",
"@types/jest": "25.2.1",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"tslint": "~5.20.1",
"tslint-microsoft-contrib": "~6.2.0",
"typescript": "~4.4.2"
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-webpack4-everything-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@rushstack/heft-webpack4-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/webpack-env": "1.13.0",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"file-loader": "~6.0.0",
"tslint": "~5.20.1",
"tslint-microsoft-contrib": "~6.2.0",
Expand Down
2 changes: 1 addition & 1 deletion build-tests/heft-webpack5-everything-test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@rushstack/heft-webpack5-plugin": "workspace:*",
"@types/heft-jest": "1.0.1",
"@types/webpack-env": "1.13.0",
"eslint": "~7.30.0",
"eslint": "~8.3.0",
"tslint": "~5.20.1",
"tslint-microsoft-contrib": "~6.2.0",
"typescript": "~4.4.2"
Expand Down
Loading