Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for enriching a SARIF log with
git blame
information. The high level algorithm is as follows:The code changes have been manually tested, but the PR currently does not introduce unit tests for the feature. The problem lies with mocking appropriate external services, since the relevant code creates local objects to interact with these external services (such as
GitHelper
).Also, the
OptionallyEmittedData.All
flag now assumes slightly different semantics, where it implies all flags except the overwrite and git blame flags. This was necessary since the existing test for theOptionallyEmittedData.All
flag does not support the preconditions for git blame.