Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach git pack-objects to ignore/delete corrupt loose objects #151

Closed
derrickstolee opened this issue Oct 4, 2019 · 3 comments
Closed

Teach git pack-objects to ignore/delete corrupt loose objects #151

derrickstolee opened this issue Oct 4, 2019 · 3 comments
Assignees
@derrickstolee
Labels
git no-activity Stale issue or PR that will be automatically closed soon.
Milestone
MVP

Comments

@derrickstolee
Copy link
Contributor

One blocker for #9 is that we will lose our implementation of ClearCorruptLooseObjects() in the LooseObjectsStep. Instead of continuing to rely on LibGit2 for that implementation, we could instead update Git to handle corrupt loose objects (given an argument).
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
@derrickstolee derrickstolee self-assigned this Oct 4, 2019
@derrickstolee derrickstolee mentioned this issue Oct 4, 2019
Merged
derrickstolee added a commit that referenced this issue Oct 7, 2019
@derrickstolee
Merge pull request #153: Delete LibGit2
2ecb17a 
Resolves #9.

Note that this removes our recovery from corrupt loose objects in the `LooseObjectsStep`. I have ideas for how to do that logic in `git pack-objects` instead #151. We may also not see corrupt objects as often now that we are using the gvfs-helper instead of the C# layer for downloading loose objects.
@github-actions
Copy link

github-actions bot commented Nov 3, 2019

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Nov 3, 2019
@jrbriggs jrbriggs removed the no-activity Stale issue or PR that will be automatically closed soon. label Nov 3, 2019
@github-actions
Copy link

github-actions bot commented Dec 3, 2019

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Dec 3, 2019
@wilbaker wilbaker removed the no-activity Stale issue or PR that will be automatically closed soon. label Dec 4, 2019
@github-actions
Copy link

github-actions bot commented Jan 3, 2020

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
git no-activity Stale issue or PR that will be automatically closed soon.
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
3 participants
@derrickstolee @jrbriggs @wilbaker