-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LibGit2 #9
Comments
The prefetch pipeline uses LibGit2. We'll want that to stay online until we have the batched read-object hook available. #7. |
Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days. |
Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days. |
Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days. |
I think this task is doable after #7 is complete. |
Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days. |
Resolves #9. Note that this removes our recovery from corrupt loose objects in the `LooseObjectsStep`. I have ideas for how to do that logic in `git pack-objects` instead #151. We may also not see corrupt objects as often now that we are using the gvfs-helper instead of the C# layer for downloading loose objects.
Can we get rid of LibGit2 entirely? Here are some tradeoffs:
CommitAndRootTreeExists()
exists for a VFS for Git reason: to see if we need to prefetch the folders at a commit on clone time so we can generate an index before projecting. This isn't needed any more.LooseObjectsStep
checks for corrupt loose objects. We'll have fewer objects with the batched read-object, and we could teachgit pack-objects
to clear corrupt objects, perhaps.Outside of that last one, many of these changes are super small and don't have a huge impact on the full story.
The text was updated successfully, but these errors were encountered: