.Net: Add tests for CRUD with no data fields and bug/test fixes #11641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
...taIntegrationTests/AzureAISearchIntegrationTests/CRUD/AzureAISearchNoDataConformanceTests.cs
Show resolved
Hide resolved
.../VectorDataIntegrationTests/RedisIntegrationTests/CRUD/RedisHashSetNoDataConformanceTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/VectorDataIntegrationTests/RedisIntegrationTests/Support/RedisTestStore.cs
Show resolved
Hide resolved
...ctorDataIntegrationTests/VectorDataIntegrationTests/CRUD/DynamicDataModelConformanceTests.cs
Outdated
Show resolved
Hide resolved
adamsitnik
approved these changes
Apr 22, 2025
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
Looks great to me, thank you for adding more test coverage @westey-m !
...orDataIntegrationTests/QdrantIntegrationTests/CRUD/QdrantDynamicDataModelConformanceTests.cs
Show resolved
Hide resolved
...t/src/VectorDataIntegrationTests/VectorDataIntegrationTests/CRUD/NoVectorConformanceTests.cs
Show resolved
Hide resolved
dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/Models/SimpleRecord.cs
Show resolved
Hide resolved
dotnet/src/VectorDataIntegrationTests/VectorDataIntegrationTests/CRUD/NoDataConformanceTests.cs
Show resolved
Hide resolved
rogerbarreto
approved these changes
Apr 22, 2025
westey-m
merged commit 4a92af9
into
microsoft:feature-vector-data-preb2
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adding tests to check for the failure reported in: #11274
The code for this area has been changed, and the issue is not reproduceable anymore.
Description
Contribution Checklist