Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Add managed identity auth support for AssistantsPlanner #1918

Open
1 of 3 tasks
Tracked by #1095
singhk97 opened this issue Aug 8, 2024 · 0 comments
Open
1 of 3 tasks
Tracked by #1095

[Feat]: Add managed identity auth support for AssistantsPlanner #1918

singhk97 opened this issue Aug 8, 2024 · 0 comments
Labels
small tshirt size small (1-4 days)

Comments

@singhk97
Copy link
Collaborator

singhk97 commented Aug 8, 2024 •
edited
Loading

Requirements
Support authenticating requests to Azure OpenAI's Assistants API using managed identity.

Tasks
Beta Give feedback
@singhk97 singhk97 self-assigned this Aug 8, 2024
@singhk97 singhk97 mentioned this issue Aug 8, 2024
Open
@singhk97 singhk97 added the small tshirt size small (1-4 days) label Aug 8, 2024
@singhk97 singhk97 mentioned this issue Aug 13, 2024
Merged
1 task
singhk97 added a commit that referenced this issue Aug 14, 2024
@singhk97
[C#] feat: AssistantsPlanner support for authenticating Azure OpenA…
ba6e806 
…I using managed identity (#1930)

## Linked issues

closes: #minor (issue number)

#1918 C# implementaiton

## Details
* Authentication Azure OpenAI endpoint requests using managed identity
auth.

#### Change details
* Updated `MathBot` and `OrderBot` to authenticate using MI if api keys
are not set.
* Added `projectId` in the `teamsapp.yml` file.

**code snippets**:

**screenshots**:

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below
@singhk97 singhk97 removed their assignment Aug 27, 2024
@singhk97 singhk97 mentioned this issue Oct 15, 2024
Open
@singhk97 singhk97 mentioned this issue Oct 30, 2024
Merged
1 task
singhk97 added a commit that referenced this issue Oct 31, 2024
@singhk97
[PY] feat: Add managed identity auth support to AssistantsPlanner (#…
3509d08 
…2153)

## Linked issues

closes: #minor
tracking: #1918

## Details
Add ability to authenticate `AssistantsPlanner` using Azure Managed
Identity by providing a `azure_ad_token_bearer` field in the initializer
options.

#### Change details
Updated samples
- math bot
- order bot

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small tshirt size small (1-4 days)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@singhk97