Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: AssistantsPlanner support for authenticating Azure OpenAI using managed identity #1930

Merged
merged 19 commits into from
Aug 14, 2024

Conversation

singhk97
Copy link
Collaborator

Linked issues

closes: #minor (issue number)

#1918 C# implementaiton

Details

  • Authentication Azure OpenAI endpoint requests using managed identity auth.

Change details

  • Updated MathBot and OrderBot to authenticate using MI if api keys are not set.
  • Added projectId in the teamsapp.yml file.

code snippets:

screenshots:

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@singhk97 singhk97 requested review from a team, aacebo, corinagum and lilyydu as code owners August 13, 2024 20:45
@singhk97 singhk97 changed the title [C#] feat: AssistantsPlanner authenticating Azure OpenAI using managed identity support. [C#] feat: AssistantsPlanner authenticating Azure OpenAI using managed identity support Aug 13, 2024
@singhk97 singhk97 changed the title [C#] feat: AssistantsPlanner authenticating Azure OpenAI using managed identity support [C#] feat: AssistantsPlanner support for authenticating Azure OpenAI using managed identity Aug 13, 2024
@singhk97 singhk97 merged commit ba6e806 into main Aug 14, 2024
16 checks passed
@singhk97 singhk97 deleted the kavin/c#-mi branch August 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants