-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] feat: AssistantsPlanner
support for authenticating Azure OpenAI using managed identity
#1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhk97
requested review from
a team,
aacebo,
corinagum and
lilyydu
as code owners
August 13, 2024 20:45
singhk97
changed the title
[C#] feat:
[C#] feat: Aug 13, 2024
AssistantsPlanner
authenticating Azure OpenAI using managed identity support.AssistantsPlanner
authenticating Azure OpenAI using managed identity support
singhk97
changed the title
[C#] feat:
[C#] feat: Aug 13, 2024
AssistantsPlanner
authenticating Azure OpenAI using managed identity supportAssistantsPlanner
support for authenticating Azure OpenAI using managed identity
aacebo
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #minor (issue number)
#1918 C# implementaiton
Details
Change details
MathBot
andOrderBot
to authenticate using MI if api keys are not set.projectId
in theteamsapp.yml
file.code snippets:
screenshots:
Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information