Skip to content

Commit

Permalink
Fix being unable to delete a changed Font Axis or Font Feature (#16790)
Browse files Browse the repository at this point in the history
Make sure the delete button's `Tag` updates when the selected
axis/feature changes, so that the correct key value gets propagated when
the delete button is clicked.

Refs #16678 #16104 

## Validation Steps Performed
1. Add a new feature/axis
2. Change the key
3. Click the delete button
4. Delete button works
  • Loading branch information
PankajBhojwani authored Mar 1, 2024
1 parent 043d5cd commit ec5d246
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/cascadia/TerminalSettingsEditor/Appearances.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@
HorizontalAlignment="Right"
Click="DeleteAxisKeyValuePair_Click"
Style="{StaticResource DeleteButtonStyle}"
Tag="{x:Bind AxisKey}">
Tag="{x:Bind AxisKey, Mode=OneWay}">
<FontIcon FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE74D;" />
</Button>
Expand Down Expand Up @@ -390,7 +390,7 @@
HorizontalAlignment="Right"
Click="DeleteFeatureKeyValuePair_Click"
Style="{StaticResource DeleteButtonStyle}"
Tag="{x:Bind FeatureKey}">
Tag="{x:Bind FeatureKey, Mode=OneWay}">
<FontIcon FontSize="{StaticResource StandardIconSize}"
Glyph="&#xE74D;" />
</Button>
Expand Down

0 comments on commit ec5d246

Please sign in to comment.