Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12] Ctrl+Shift+Wheel no longer works on Windows 10 #11285

Closed
DHowett opened this issue Sep 20, 2021 · 0 comments · Fixed by #11372
Closed

[1.12] Ctrl+Shift+Wheel no longer works on Windows 10 #11285

DHowett opened this issue Sep 20, 2021 · 0 comments · Fixed by #11372
Assignees
@zadjii-msft
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.12

Comments

@DHowett
Copy link
Member

DHowett commented Sep 20, 2021 •
edited by zadjii-msft
Loading

This is because we now prefer vintage opacity.

Regressed in #11180.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 20, 2021
@DHowett DHowett added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Sep 20, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 20, 2021
@DHowett DHowett added this to the Terminal v1.12 milestone Sep 20, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 20, 2021
Merged
4 tasks
@zadjii-msft zadjii-msft changed the title [1/12] Ctrl+Shift+Wheel no longer works on Windows 10 [1.12] Ctrl+Shift+Wheel no longer works on Windows 10 Sep 20, 2021
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 20, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 29, 2021
Closed
zadjii-msft added a commit that referenced this issue Sep 29, 2021
@zadjii-msft
When enabling opacity on win10, automatically enable acrylic
93831f1 
   In #11180 we made `opacity` independent from `useAcrylic`. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic.

   However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity.

   * [x] Closes #11285
@zadjii-msft zadjii-msft mentioned this issue Sep 29, 2021
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Sep 29, 2021
@ghost ghost closed this as completed in #11372 Oct 7, 2021
ghost pushed a commit that referenced this issue Oct 7, 2021
@zadjii-msft
When enabling opacity on win10, automatically enable acrylic (#11372)
694c6b2 
In #11180 we made `opacity` independent from `useAcrylic`. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic.

However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity.

* [x] Closes #11285

SUI changes in action:

![auto-acrylic-win10](https://user-images.githubusercontent.com/18356694/136281935-db9a10f4-e0ad-4422-950b-0a01dc3e12c0.gif)
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 7, 2021
@zadjii-msft zadjii-msft mentioned this issue Dec 2, 2022
Merged
ghost pushed a commit that referenced this issue Dec 9, 2022
@zadjii-msft
Enable vintage opacity on Windows 10 (#14481)
a5c5b8a 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least. 

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least
DHowett pushed a commit that referenced this issue Dec 12, 2022
@zadjii-msft @DHowett
Enable vintage opacity on Windows 10 (#14481)
e1fccd8 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176746
Service-Version: 1.16
DHowett pushed a commit that referenced this issue Dec 12, 2022
@zadjii-msft @DHowett
Enable vintage opacity on Windows 10 (#14481)
32b7c24 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176745
Service-Version: 1.15
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

When enabling opacity on win10, automatically enable acrylic microsoft/terminal
2 participants
@DHowett @zadjii-msft