Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When enabling opacity on win10, automatically enable acrylic #11372

Merged
11 commits merged into from
Oct 7, 2021
Merged

When enabling opacity on win10, automatically enable acrylic #11372

11 commits merged into from
Oct 7, 2021

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Sep 29, 2021 •
edited
Loading

In #11180 we made opacity independent from useAcrylic. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic.

However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity.

SUI changes in action:

auto-acrylic-win10

@zadjii-msft
When enabling opacity on win10, automatically enable acrylic
93831f1 
   In #11180 we made `opacity` independent from `useAcrylic`. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic.

   However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity.

   * [x] Closes #11285
@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Sep 29, 2021
@WSLUser
Copy link
Contributor

WSLUser commented Sep 29, 2021 •
edited
Loading

to enable acrylic in hyper-V

I think this would be important to add to the docs for users that enable the setting. I would assume the registry key would be needed by other VM software like VMWare and VirtualBox too?

carlos-zamora
carlos-zamora approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want something similar for SUI?

I'm approving because you may prefer for that to be a follow-up (presumably, we'd have to update some localized resources for that.)

src/cascadia/TerminalControl/ControlCore.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalControl/ControlCore.cpp Outdated Show resolved Hide resolved
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Sep 29, 2021 •
edited by DHowett
Loading

Don't we want something similar for SUI?

Oh, ew. Frick I forgot about that. I'll give that a bit of effort tomorrow, but honestly it might be easiest to not worry about this and just let this get serviced (#11371)

I actually did test this in a Win10 VM, but you need

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\Dwm]
"ForceEffectMode"=dword:00000002

to enable acrylic in hyper-V

@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Oct 5, 2021
@DHowett
Copy link
Member

DHowett commented Oct 6, 2021

to enable acrylic in hyper-V

I think this would be important to add to the docs for users that enable the setting. I would assume the registry key would be needed by other VM software like VMWare and VirtualBox too?

We won't be documenting other people's private registry keys. If this was owned by our team, sure, but we don't step on our colleagues' toes like that 😄

@DHowett
Copy link
Member

DHowett commented Oct 6, 2021

(In fact, I moved it out of the body of the commit so it didn't end up in history forever 😄)

@zadjii-msft
Copy link
Member Author

of course the ci runs on windows 10

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Oct 6, 2021
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 7, 2021
@ghost
Copy link

ghost commented Oct 7, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 694c6b2 into main Oct 7, 2021
@ghost ghost deleted the dev/migrie/b/11285-opacity-on-win10 branch October 7, 2021 11:39
zadjii-msft added a commit that referenced this pull request Oct 28, 2021
@zadjii-msft
Fix the opacity slider
0979a54 
  I can't even write a description for this. Just read the code change, you'll see what I goofed.

  Regressed in #11372

  Closes #11555
@zadjii-msft zadjii-msft mentioned this pull request Oct 28, 2021
Merged
ghost pushed a commit that referenced this pull request Oct 29, 2021
@zadjii-msft
Fix the opacity slider (#11643)
1cedac6 
I can't even write a description for this. Just read the code change, you'll see what I goofed.

Regressed in #11372

Closes #11555
DHowett pushed a commit that referenced this pull request Dec 13, 2021
@zadjii-msft @DHowett
Fix the opacity slider (#11643)
aaabce7 
I can't even write a description for this. Just read the code change, you'll see what I goofed.

Regressed in #11372

Closes #11555

(cherry picked from commit 1cedac6)
@zadjii-msft zadjii-msft mentioned this pull request Dec 2, 2022
Merged
ghost pushed a commit that referenced this pull request Dec 9, 2022
@zadjii-msft
Enable vintage opacity on Windows 10 (#14481)
a5c5b8a 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least. 

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@zadjii-msft @DHowett
Enable vintage opacity on Windows 10 (#14481)
e1fccd8 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176746
Service-Version: 1.16
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@zadjii-msft @DHowett
Enable vintage opacity on Windows 10 (#14481)
32b7c24 
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176745
Service-Version: 1.15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. zBugBash-Consider
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging this pull request may close these issues.

[1.12] Ctrl+Shift+Wheel no longer works on Windows 10
5 participants
@zadjii-msft @WSLUser @DHowett @lhecker @carlos-zamora