Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting transparency slider re-enables acrylic #11555

Closed
heaths opened this issue Oct 20, 2021 · 3 comments · Fixed by #11643
Closed

Adjusting transparency slider re-enables acrylic #11555

heaths opened this issue Oct 20, 2021 · 3 comments · Fixed by #11643
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.13

Comments

@heaths
Copy link
Member

heaths commented Oct 20, 2021

Windows Terminal version (or Windows build number)

1.12.2922.0

Other Software

  • Windows 11 version 21H2 (OS Build 22000.258)

Steps to reproduce

  1. Open settings.
  2. Go to default profile Appearance (or some individual profile's Appearance)
  3. Adjust transparency slider
  4. Disable acrylic
  5. Adjust transparency slider again

Expected Behavior

Acrylic remains in previous, disabled state.

Actual Behavior

Acrylic is re-enabled.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 20, 2021
@zadjii-msft
Copy link
Member

Heck I was just about to file this. I'm definitely the murderer on this one, but I thought I gated that behavior behind windows 10 only...

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Oct 20, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 20, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Oct 20, 2021
@heaths
Copy link
Member Author

heaths commented Oct 20, 2021

BTW: traditional transparency: 😍

zadjii-msft added a commit that referenced this issue Oct 28, 2021
@zadjii-msft
Fix the opacity slider
0979a54 
  I can't even write a description for this. Just read the code change, you'll see what I goofed.

  Regressed in #11372

  Closes #11555
@zadjii-msft zadjii-msft mentioned this issue Oct 28, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 28, 2021
@ghost ghost closed this as completed in #11643 Oct 29, 2021
ghost pushed a commit that referenced this issue Oct 29, 2021
@zadjii-msft
Fix the opacity slider (#11643)
1cedac6 
I can't even write a description for this. Just read the code change, you'll see what I goofed.

Regressed in #11372

Closes #11555
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 29, 2021
DHowett pushed a commit that referenced this issue Dec 13, 2021
@zadjii-msft @DHowett
Fix the opacity slider (#11643)
aaabce7 
I can't even write a description for this. Just read the code change, you'll see what I goofed.

Regressed in #11372

Closes #11555

(cherry picked from commit 1cedac6)
@ghost
Copy link

ghost commented Dec 14, 2021

🎉This issue was addressed in #11643, which has now been successfully released as Windows Terminal Preview v1.12.3472.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2022
Closed
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Jan 21, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.13
Development

Successfully merging a pull request may close this issue.

Fix the opacity slider microsoft/terminal
3 participants
@DHowett @heaths @zadjii-msft