Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.17 still displays launch params (Default,Default) despite values being set #14469

Closed
DHowett opened this issue Nov 30, 2022 · 1 comment · Fixed by #14518
Closed

1.17 still displays launch params (Default,Default) despite values being set #14469

DHowett opened this issue Nov 30, 2022 · 1 comment · Fixed by #14518
Assignees
@PankajBhojwani
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.17

Comments

@DHowett
Copy link
Member

DHowett commented Nov 30, 2022 •
edited
Loading

image
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 30, 2022
@PankajBhojwani PankajBhojwani removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 30, 2022
@PankajBhojwani PankajBhojwani self-assigned this Nov 30, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 30, 2022
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. Priority-1 A description (P1) Area-SettingsUI Anything specific to the SUI Product-Terminal The new Windows Terminal. labels Dec 2, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 2, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Dec 2, 2022
@PankajBhojwani PankajBhojwani mentioned this issue Dec 8, 2022
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 8, 2022
@ghost ghost closed this as completed in #14518 Dec 9, 2022
ghost pushed a commit that referenced this issue Dec 9, 2022
@PankajBhojwani
Fix setting launch position in the Settings UI not working (#14518)
b9c3b5c 
## Summary of the Pull Request
This change should have been a part of #14190 but was missed. 

## PR Checklist
* [x] Closes #14469 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
Setting launch position in the settings UI works now
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 9, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14518, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Fix setting launch position in the Settings UI not working microsoft/terminal
3 participants
@DHowett @zadjii-msft @PankajBhojwani