Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting launch position in the Settings UI not working #14518

Merged
1 commit merged into from
Dec 9, 2022
Merged

Fix setting launch position in the Settings UI not working #14518

1 commit merged into from
Dec 9, 2022

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

This change should have been a part of #14190 but was missed.

PR Checklist

Validation Steps Performed

Setting launch position in the settings UI works now

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Dec 8, 2022
zadjii-msft
zadjii-msft approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAIT REALLY? THATS IT‽

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b9c3b5c into main Dec 9, 2022
@ghost ghost deleted the dev/pabhoj/fix_launch_params branch December 9, 2022 17:51
@DHowett
Copy link
Member

DHowett commented Dec 9, 2022

@PankajBhojwani was launch position UI part of 1.16?

@ianjoneill
Copy link
Contributor

There's still something a bit funky with this:

LaunchPosition.mp4

@ianjoneill ianjoneill mentioned this pull request Dec 10, 2022
Merged
@ianjoneill
Copy link
Contributor

^ This is fixed in #14522

ghost pushed a commit that referenced this pull request Dec 13, 2022
@ianjoneill
Ensure X/Y controls are updated when default launch pos selected (#14522
6a763bc 
)

Ensures the X & Y XAML controls are updated when the default launch position checkbox is toggled.
References #14518
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 24, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. zBugBash-Consider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.17 still displays launch params (Default,Default) despite values being set
5 participants
@PankajBhojwani @DHowett @ianjoneill @carlos-zamora @zadjii-msft