Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure X/Y controls are updated when default launch pos selected #14522

Merged
1 commit merged into from
Dec 13, 2022
Merged

Ensure X/Y controls are updated when default launch pos selected #14522

1 commit merged into from
Dec 13, 2022

Conversation

ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented Dec 10, 2022 •
edited by DHowett
Loading

Ensures the X & Y XAML controls are updated when the default launch position checkbox is toggled.
References #14518

@ianjoneill ianjoneill mentioned this pull request Dec 10, 2022
Merged
6 tasks
@ianjoneill
Copy link
Contributor Author

I must be extremely unlucky with the CI.

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Dec 12, 2022
PankajBhojwani
PankajBhojwani approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@PankajBhojwani PankajBhojwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DHowett DHowett changed the title Ensure X & Y XAML controls are updated when default launch pos selected Ensure X/Y controls are updated when default launch pos selected Dec 12, 2022
DHowett
DHowett approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DHowett
Copy link
Member

DHowett commented Dec 12, 2022

And yes, we have all been getting quite unlucky with the CI. It's not a good look.

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6a763bc into microsoft:main Dec 13, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ianjoneill @DHowett @zadjii-msft @PankajBhojwani