Terminal ignores Profile termination behavior setting

[Avi0]

Windows Terminal version

1.19.2682.0

Windows build number

10.0.22621.0

Other Software

WSL

Steps to reproduce

Set Profile termination behavior to "Close when process exits, fails, or crashes". Make profile exit with non-zero exit code. I can reproduce this in WSL, for example, by listing a non-existing file ls 123, then exit.

Expected Behavior

Tab closes silently. (Terminal 1.18 closes tab silently in this case).

Actual Behavior

This message is displayed:

[process exited with code 2 (0x00000002)]
You can now close this terminal with Ctrl+D, or press Enter to restart.

[joaoricarte]

I am in the same terminal version and I can confirm this issue. In the previous version, this wouldn't happen.

[zadjii-msft]

notes:

terminal/src/cascadia/TerminalApp/Pane.cpp

Lines 1069 to 1076 in 1669036

	const auto previousConnectionState = std::exchange(_connectionState, newConnectionState);
	if (previousConnectionState < ConnectionState::Connected && newConnectionState >= ConnectionState::Failed)
	{
	// A failure to complete the connection (before it has _connected_) is not covered by "closeOnExit".
	// This is to prevent a misconfiguration (closeOnExit: always, startingDirectory: garbage) resulting
	// in Terminal flashing open and immediately closed.
	co_return;
	}

When we get there as we're exiting, previousConnectionState is evaluated as... NotConnected? So we never propogated up the Connecting, Connected? weird....

oh derp
literally just above that:

terminal/src/cascadia/TerminalApp/Pane.cpp

Lines 1043 to 1047 in 1669036

	if (newConnectionState < ConnectionState::Closed)
	{
	// Pane doesn't care if the connection isn't entering a terminal state.
	co_return;
	}