Fix closeOnExit: always
#16090
Merged
Fix closeOnExit: always
#16090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
zadjii-msft
commented
Oct 2, 2023
| @@ -1040,6 +1040,7 @@ winrt::fire_and_forget Pane::_ControlConnectionStateChangedHandler(const winrt:: | |||
| newConnectionState = coreState.ConnectionState(); | |||
| } | |||
|
|
|||
| const auto previousConnectionState = std::exchange(_connectionState, newConnectionState); | |||
There was a problem hiding this comment.
/cc @lhecker to make sure I didn't royally blow up some locking / co_await / other threading issue, which I am prone to do
carlos-zamora
approved these changes
Oct 2, 2023
lhecker
approved these changes
Oct 2, 2023
DHowett
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, Pane doesn't only care if the connection isn't entering a terminal state. It does need to update its own state first.
Regressed in #15335
Closes #16068